public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: U Boot <u-boot@lists.denx.de>
Subject: [BUG] include/generated/environment.h included incorrectly
Date: Fri, 25 Feb 2022 00:30:23 -0500	[thread overview]
Message-ID: <f2d44fa8-c044-24f6-59ce-d13c8dff13ae@gmail.com> (raw)


Hi Simon,



include/generated/environment.h is still included if it exists, even if

CONFIG_USE_DEFAULT_ENV_FILE is not set. To reproduce this, build a board

which uses this config (such as sandbox), and then build a board which

does not. You should see the following error:



In file included from env/common.c:32:

include/env_default.h:113:3: error: #error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"

   113 | # error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"

       |   ^~~~~



--Sean


             reply	other threads:[~2022-02-25  5:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25  5:30 Sean Anderson [this message]
2022-03-12  5:37 ` [BUG] include/generated/environment.h included incorrectly Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2d44fa8-c044-24f6-59ce-d13c8dff13ae@gmail.com \
    --to=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox