* [BUG] include/generated/environment.h included incorrectly
@ 2022-02-25 5:30 Sean Anderson
2022-03-12 5:37 ` Simon Glass
0 siblings, 1 reply; 2+ messages in thread
From: Sean Anderson @ 2022-02-25 5:30 UTC (permalink / raw)
To: Simon Glass; +Cc: U Boot
Hi Simon,
include/generated/environment.h is still included if it exists, even if
CONFIG_USE_DEFAULT_ENV_FILE is not set. To reproduce this, build a board
which uses this config (such as sandbox), and then build a board which
does not. You should see the following error:
In file included from env/common.c:32:
include/env_default.h:113:3: error: #error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"
113 | # error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"
| ^~~~~
--Sean
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUG] include/generated/environment.h included incorrectly
2022-02-25 5:30 [BUG] include/generated/environment.h included incorrectly Sean Anderson
@ 2022-03-12 5:37 ` Simon Glass
0 siblings, 0 replies; 2+ messages in thread
From: Simon Glass @ 2022-03-12 5:37 UTC (permalink / raw)
To: Sean Anderson; +Cc: U Boot
Hi Sean,
On Thu, 24 Feb 2022 at 22:30, Sean Anderson <seanga2@gmail.com> wrote:
>
>
> Hi Simon,
>
>
>
> include/generated/environment.h is still included if it exists, even if
>
> CONFIG_USE_DEFAULT_ENV_FILE is not set. To reproduce this, build a board
>
> which uses this config (such as sandbox), and then build a board which
>
> does not. You should see the following error:
>
>
>
> In file included from env/common.c:32:
>
> include/env_default.h:113:3: error: #error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"
>
> 113 | # error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"
>
> | ^~~~~
>
I created https://source.denx.de/u-boot/u-boot/-/issues/9
Regards,
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-12 5:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-25 5:30 [BUG] include/generated/environment.h included incorrectly Sean Anderson
2022-03-12 5:37 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox