From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09F81C433EF for ; Fri, 25 Feb 2022 05:30:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6AE1783C59; Fri, 25 Feb 2022 06:30:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZFsWEDX8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3CE2083C5B; Fri, 25 Feb 2022 06:30:28 +0100 (CET) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5643C83C58 for ; Fri, 25 Feb 2022 06:30:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x736.google.com with SMTP id f10so3691459qkg.9 for ; Thu, 24 Feb 2022 21:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=J9mN/8SWUb5GaeenJfWfhRtjB5XGYiiV+FLA3gqnhXI=; b=ZFsWEDX8m8S3cf+7t7raSjQao1wQAs9+WXesa5LV/0wlFGkcy+7AX+APu/zzkGbhFe Az4PGlYGd+h5cpSeD6GsRhfIgmBbkwBsAFPVI0KY5RDGHL7HN86Myxy8bVPA1+djzbT/ NAgKqARjZnnbKnTFq7FOJo5RPnpIq8DEXqXvf3goyi0owCfmwbUz4lHjnuExk0PqUkmJ C5LPaUj4s9iunvnkwO9Mo6OvLVL1mlrDWr9q5U0NAHi3l7y+k3nGU/Xd4w0stFhNDotM fe6ZqFeeY92IRp8zQHD1XrV3z7QQFoNhhsglDTmZy6nVd59qsTyL7hd55+NOmFcUZOWg AIiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=J9mN/8SWUb5GaeenJfWfhRtjB5XGYiiV+FLA3gqnhXI=; b=F4TthpXcDg1vfIT+aCrqiamLbWGk9/PhQvvjO25FTzxQFzLVG0BuhgkiEhG9oqQovX SngtzWSymXlAfLr867bS0zPT1KBvsPg7FwA4R9L3mACQ7cmnF3Hg5dBoG6LOkG+BK4J3 sHnUoOHEmrd8vQ9+31xS4dRFJ3TyxbQEXb1g4QFDRD96wHlZMFKyG/qTReOTITFgDp9u cZyJgQafCcm4rs735bG4bTDim4MwOeHKHdDzh2ZZEt5PTEdyApl6GmzPdI39S4N3SaAx IYTmrMmgpu85GwphURC55aKfdtwVqO+TJTF71xYJdzJEDU6tQ/B6cUYJUVzpqXqRnOTA NWAw== X-Gm-Message-State: AOAM532PsfRpyfYTW7B1Kxzyy/cgzOp7rJXhTSiIycHt/27D1stRV0Tj xREq3TsU4c/heTWOyHS84pqObyCXg5g= X-Google-Smtp-Source: ABdhPJyaWN0cU+6zQr9XqQ1JDuovjWm9DQEb30QOHNviUF0n9GEuVMGkwe0XP5Mz4Fp25q/ssKv6Hw== X-Received: by 2002:a37:9b0a:0:b0:475:f496:8840 with SMTP id d10-20020a379b0a000000b00475f4968840mr3816143qke.268.1645767024050; Thu, 24 Feb 2022 21:30:24 -0800 (PST) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id d4-20020a05620a136400b0060dda40b3ecsm804066qkl.30.2022.02.24.21.30.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 21:30:23 -0800 (PST) To: Simon Glass Cc: U Boot From: Sean Anderson Subject: [BUG] include/generated/environment.h included incorrectly Message-ID: Date: Fri, 25 Feb 2022 00:30:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Simon, include/generated/environment.h is still included if it exists, even if CONFIG_USE_DEFAULT_ENV_FILE is not set. To reproduce this, build a board which uses this config (such as sandbox), and then build a board which does not. You should see the following error: In file included from env/common.c:32: include/env_default.h:113:3: error: #error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS" 113 | # error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS" | ^~~~~ --Sean