Re: [PATCH v6 15/24] soc: qcom: add build infrastructure

[Neil Armstrong <neil.armstrong@linaro.org>]

On 15/07/2024 12:08, Caleb Connolly wrote:
> Add Kconfig / Makefiles to build rpmh and cmd-db drivers.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>   drivers/soc/Kconfig       |  1 +
>   drivers/soc/Makefile      |  1 +
>   drivers/soc/qcom/Kconfig  | 27 +++++++++++++++++++++++++++
>   drivers/soc/qcom/Makefile |  4 ++++
>   4 files changed, 33 insertions(+)
> 
> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig
> index cee506fe4747..8ef408d9ba1b 100644
> --- a/drivers/soc/Kconfig
> +++ b/drivers/soc/Kconfig
> @@ -47,8 +47,9 @@ config SOC_XILINX_VERSAL_NET
>   	  Enable this option to select SoC device id driver for Xilinx Versal NET.
>   	  This allows other drivers to verify the SoC familiy & revision using
>   	  matching SoC attributes.
>   
> +source "drivers/soc/qcom/Kconfig"
>   source "drivers/soc/samsung/Kconfig"
>   source "drivers/soc/ti/Kconfig"
>   
>   endmenu
> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
> index 5ec89a053165..00e6a5ac8e2b 100644
> --- a/drivers/soc/Makefile
> +++ b/drivers/soc/Makefile
> @@ -2,8 +2,9 @@
>   #
>   # Makefile for the U-Boot SOC specific device drivers.
>   
>   obj-$(CONFIG_SOC_AMD_VERSAL2) += soc_amd_versal2.o
> +obj-$(CONFIG_SOC_QCOM) += qcom/
>   obj-$(CONFIG_SOC_SAMSUNG) += samsung/
>   obj-$(CONFIG_SOC_TI) += ti/
>   obj-$(CONFIG_SOC_DEVICE) += soc-uclass.o
>   obj-$(CONFIG_SOC_DEVICE_TI_K3) += soc_ti_k3.o
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> new file mode 100644
> index 000000000000..4aa7833930c7
> --- /dev/null
> +++ b/drivers/soc/qcom/Kconfig
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# QCOM Soc drivers
> +#
> +menuconfig SOC_QCOM
> +	bool "Qualcomm SOC drivers support"
> +	help
> +	  Say Y here if you want to enable Qualcomm SOC drivers support.
> +
> +if SOC_QCOM
> +
> +config QCOM_COMMAND_DB
> +	bool "Qualcomm Command DB"
> +	help
> +	  Command DB queries shared memory by key string for shared system
> +	  resources. Platform drivers that require to set state of a shared
> +	  resource on a RPM-hardened platform must use this database to get
> +	  SoC specific identifier and information for the shared resources.
> +
> +config QCOM_RPMH
> +	bool "Qualcomm RPMh support"
> +	depends on QCOM_COMMAND_DB
> +	help
> +	  Say y here to support the Qualcomm RPMh (resource peripheral manager)
> +	  if you need to control regulators on Qualcomm platforms, say y here.
> +
> +endif # SOC_QCOM
> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
> new file mode 100644
> index 000000000000..78fae8bbfa16
> --- /dev/null
> +++ b/drivers/soc/qcom/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +
> +obj-$(CONFIG_QCOM_COMMAND_DB) += cmd-db.o
> +obj-$(CONFIG_QCOM_RPMH) += rpmh-rsc.o rpmh.o
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>