Re: [RFC PATCH 22/31] test: lmb: run the LMB tests only on sandbox

[Heinrich Schuchardt <xypron.glpk@gmx.de>]

On 11.06.24 10:55, Sughosh Ganu wrote:
> On Mon, 10 Jun 2024 at 23:14, Tom Rini <trini@konsulko.com> wrote:
>>
>> On Sat, Jun 08, 2024 at 12:22:31AM +0530, Sughosh Ganu wrote:
>>
>>> The LMB memory map is now persistent and global. Running the tests for
>>> the LMB module will result in the memory map getting reset, and this
>>> will have side-effects on the rest of the working of the platform. Run
>>> the LMB tests only on the sandbox platform, which is meant for running
>>> such kinds of tests.
>>>
>>> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
>>
>> I'm not sure about this. We can reset real hardware as often as we need,
>> too. Did you run in to problems with this test on non-sandbox?
>
> But do we want to reset the state of the LMB memory map on real
> hardware? This was working up until now because of the local nature of
> the LMB variables. But if the LMB memory map is to be persistent,
> should we allow it to be changed for running some test? That would
> have side effects? I think running these tests on sandbox should
> suffice. I mean there isn't any aspect of the LMB module that is not
> getting tested on sandbox, right?
>
> -sughosh

We should run tests on systems with different bitness and endianness.

As the LMB test does not rely on any sandbox driver we should be able to
run it on any system.

If the memory map is not usable anymore after the test, the system
should be rebooted.

Best regards

Heinrich