public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dalon L Westergreen <dalon.westergreen@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] spl: socfpga: only gen5 devices and arria10 require sfp image
Date: Thu, 06 Sep 2018 06:30:28 -0700	[thread overview]
Message-ID: <f5403fcff81dc0dceff7d70be90d1f9f3f987a98.camel@linux.intel.com> (raw)
In-Reply-To: <7b565d14-10c5-e9f6-8fc5-49b5697b3256@denx.de>

On Thu, 2018-09-06 at 12:08 +0200, Marek Vasut wrote:
> On 09/06/2018 05:02 AM, Dalon Westergreen wrote:
> 
> Only the Cyclone5/Arria5 and Arria10 devices require the sfp
> formated image for booting. This path ensures that the file is
> only generated for those devices.
> 
> Signed-off-by: Dalon Westergreen <dwesterg@gmail.com>
> ---
>  scripts/Makefile.spl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
> index 252f13826d..76d08fd92b 100644
> --- a/scripts/Makefile.spl
> +++ b/scripts/Makefile.spl
> @@ -188,7 +188,8 @@ ALL-y	+= $(obj)/$(BOARD)-spl.bin
>  endif
>  
>  ifdef CONFIG_ARCH_SOCFPGA
> -ALL-y	+= $(obj)/$(SPL_BIN).sfp
> +ALL-$(CONFIG_TARGET_SOCFPGA_GEN5)	+= $(obj)/$(SPL_BIN).sfp
> +ALL-$(CONFIG_TARGET_SOCFPGA_ARRIA10)	+= $(obj)/$(SPL_BIN).sfp
>  endif
>  
>  ifdef CONFIG_ARCH_SUNXI
> 
> What about adding Kconfig option , something like
> CONFIG_TARGET_SOCFPGA_SFP , using it above and enabling it on Gen5 and
> A10 ? That way ,we won't have two entries with the same content.
> 
Good idea.

      reply	other threads:[~2018-09-06 13:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06  3:02 [U-Boot] [PATCH v2 1/2] spl: socfpga: only gen5 devices and arria10 require sfp image Dalon Westergreen
2018-09-06  3:02 ` [U-Boot] [PATCH v2 2/2] spl: socfpga: stratix10: add hex file output for spl image Dalon Westergreen
2018-09-06  5:51   ` Simon Goldschmidt
2018-09-06 13:49     ` Dalon L Westergreen
2018-09-06 10:09   ` Marek Vasut
2018-09-06 13:39     ` Dalon L Westergreen
2018-09-06 13:41       ` Marek Vasut
2018-09-06 17:40         ` Dalon L Westergreen
2018-09-06 18:16           ` Marek Vasut
2018-09-06 21:26         ` Dalon L Westergreen
2018-09-06 21:56           ` Marek Vasut
2018-09-07 16:15             ` Dalon L Westergreen
2018-09-07 16:25               ` Marek Vasut
2018-09-07 16:40                 ` Dalon L Westergreen
2018-09-07 17:36                   ` Marek Vasut
2018-09-07 18:02                     ` Westergreen, Dalon
2018-09-07 18:17                       ` Marek Vasut
2018-09-06 10:08 ` [U-Boot] [PATCH v2 1/2] spl: socfpga: only gen5 devices and arria10 require sfp image Marek Vasut
2018-09-06 13:30   ` Dalon L Westergreen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5403fcff81dc0dceff7d70be90d1f9f3f987a98.camel@linux.intel.com \
    --to=dalon.westergreen@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox