From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= Date: Wed, 19 Apr 2017 07:27:58 +0200 Subject: [U-Boot] [PATCH v3 02/15] sysreset-uclass: ensure udevice is probed before requesting reset In-Reply-To: References: <1492293846-10640-1-git-send-email-noltari@gmail.com> <1492547924-32523-1-git-send-email-noltari@gmail.com> <1492547924-32523-3-git-send-email-noltari@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi Simon, El 19/04/2017 a las 2:13, Simon Glass escribió: > Hi Alvaro, > > On 18 April 2017 at 14:38, Álvaro Fernández Rojas wrote: >> This causes exceptions for drivers that aren't probed when reboot is >> requested. >> >> Signed-off-by: Álvaro Fernández Rojas >> --- >> v3: add new patch to ensure that the device is probed >> >> drivers/sysreset/sysreset-uclass.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/sysreset/sysreset-uclass.c b/drivers/sysreset/sysreset-uclass.c >> index 3566d17..329dc2e 100644 >> --- a/drivers/sysreset/sysreset-uclass.c >> +++ b/drivers/sysreset/sysreset-uclass.c >> @@ -34,6 +34,9 @@ int sysreset_walk(enum sysreset_t type) >> for (uclass_first_device(UCLASS_SYSRESET, &dev); >> dev; >> uclass_next_device(&dev)) { >> + if (!device_active(dev) && device_probe(dev)) >> + continue; > > uclass_first_device() should activate the device. Can you please dig > into what is going on here? I'll try to investigate it later today or tomorrow... Could this be related to core/uclass: uclass_get_device_tail: always set devp? http://patchwork.ozlabs.org/patch/751929/ > >> + >> ret = sysreset_request(dev, type); >> if (ret == -EINPROGRESS) >> break; >> -- >> 2.1.4 >> > > Regards, > Simon > Regards, Álvaro.