From: Tirumala Marri <tmarri@apm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] APM82xxx: Add CPU and other peripheral support
Date: Thu, 2 Sep 2010 11:01:53 -0700 [thread overview]
Message-ID: <f5b257a2367890d26637726f5c8e1dea@mail.gmail.com> (raw)
In-Reply-To: <20100902115535.98934153781@gemini.denx.de>
Mr Wolfgang,
>
> On the other hand, this seems to be a 464 core, so should we not print
> 464 here?
[Marri] Interesting point, For all other processors we were printing SoC
name not the CPU core name.
APM82xxx is SoC name.
> > diff --git a/include/ppc440.h b/include/ppc440.h
> > index c807dda..b5c1832 100644
> > --- a/include/ppc440.h
> > +++ b/include/ppc440.h
>
> Hm... you are adding a number of large blocks of code, all #ifdef'ed.
>
> This is ugly, difficult to read and difficult to maintain.
>
> Why not adding a new file include/apm82xxx.h instead?
>
[Marri] If we create new file it would cause too many changes in the
common files.
When more and more APM8xxxx processors with new registers definitions
being released
At that point we can create separate file. Please suggest ?
Regards,
Marri
next prev parent reply other threads:[~2010-09-02 18:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 1:16 [U-Boot] [PATCH v2 1/2] APM82xxx: Add CPU and other peripheral support tmarri at apm.com
2010-09-02 11:55 ` Wolfgang Denk
2010-09-02 18:01 ` Tirumala Marri [this message]
2010-09-02 19:01 ` Wolfgang Denk
2010-09-03 7:46 ` Stefan Roese
2010-09-03 8:32 ` Wolfgang Denk
2010-09-03 11:26 ` Stefan Roese
2010-09-03 1:48 ` Tirumala Marri
2010-09-03 7:18 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5b257a2367890d26637726f5c8e1dea@mail.gmail.com \
--to=tmarri@apm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox