From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61000C77B72 for ; Mon, 17 Apr 2023 10:17:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B8FC785EE0; Mon, 17 Apr 2023 12:17:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="RZAVD91c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 32E8C85EE5; Mon, 17 Apr 2023 12:17:24 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20614.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::614]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DF34985ED8 for ; Mon, 17 Apr 2023 12:17:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UkExSQaoYLbm94i9PLr7KqRwRLk7Tm5peGps9quDZTEdqKjvE1WAcSq7iDW1J52Nu/UqUhDqttVpX5l0A4htYunkKlKbWHJracQ/+aF/5UDLssy0tgtAbuT4/mZDMtDVLs1Qhlsq2Tc4C8wv6VMUWX0nyyz+d6cceYG+wva8VUT9qrgPz+eIML670X+WLpvQSwb7gMTjV4QDym/flDC1m4wRW8cxWQcfnRNHhEW70lcr67aeXyPw1cp0fmwet6IgLTB64d9LG4rEOfKJ3VcexuEscyeUT1tNVfjPhbkRcdxx2yMNh+m7RN+XrS6xPRDXt9LS8JRYsvFNSqwJsG4CwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nK3iN2CyVIuivt2mGwxLCerhFXjj1xw1N/be+exLtqI=; b=Ci6o1B/tDBFd4mc9SZ/9iUF3Y5xeW+9HK3m3Cn1AbEceIe2zx4Dx5qCFYzI8jdZoaQOCBKC9tMUaQrCKd7Ym4nmO4lkakaR8H57fJpL9IuNcUe/1m1zEzPejP+q953Fj5p3/lJZv6u6yOJoEje9edh63KZ257ImhKSabkWV+5L12oIAsS9ilJwFvd/W1mHdcOwF5k6okqsioVZc7fIpDajEZSrlWoP80WVYNTsAx5snNawXFG15eRnH+AoIq7WeQOApA1Ih6po3wr3f1+NVa6MbfSXz4NjOO5kBOBrW8YlBCgvhdx7/T5g7Cde2sFJHQD6A1KURnGyLED95y+6Xqlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nK3iN2CyVIuivt2mGwxLCerhFXjj1xw1N/be+exLtqI=; b=RZAVD91cJisraYZHgMxxZ5CliKiRkOdKUFYpQf79HERS9pLJ2XpSf2O7NNZ8FbQAkUk+GDqTmx9bzr3Dmk4DLGZKze1yzWPzX5dfaE0JgXl+qArrnLqcqRJyrir5srG262p+/Tn6l+DPUulm7eiP3w+7mF5HEnwuk1fMYTuSAjM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) by MN2PR12MB4109.namprd12.prod.outlook.com (2603:10b6:208:1d9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Mon, 17 Apr 2023 10:17:16 +0000 Received: from BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::8c5f:e48:a658:7611]) by BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::8c5f:e48:a658:7611%2]) with mapi id 15.20.6298.045; Mon, 17 Apr 2023 10:17:16 +0000 Message-ID: Date: Mon, 17 Apr 2023 12:17:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] Revert "spi: zynq_qspi: Use dummy buswidth in dummy byte calculation" Content-Language: en-US To: Stefan Herbrechtsmeier , u-boot@lists.denx.de, "Soma, Ashok Reddy" Cc: Stefan Herbrechtsmeier , Jagan Teki References: <20230331144440.30575-1-stefan.herbrechtsmeier-oss@weidmueller.com> From: Michal Simek In-Reply-To: <20230331144440.30575-1-stefan.herbrechtsmeier-oss@weidmueller.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::20) To BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB4758:EE_|MN2PR12MB4109:EE_ X-MS-Office365-Filtering-Correlation-Id: c64e28be-c372-48d9-9419-08db3f2ceb15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b2SyUV7gNJR2StEACcLtCozVxszwyaVWCYxvaXWeapMwxhvV501W9ZpfCcDNS7/GcAic/FN5OT0pnJHK1q1PzaoddGENIsliYSWfZwqgPy16/Mkw9EFCNCWzOA1w0GvbhMBCuZcp8CppUCobNfWIY9YNLqb4KgWJHM55USe3nQ8gYgoemtZYWBQ2g7HOateixhQ/5gA6qt8es6SAZwR8zE24dLa0s6/WTBoa7rlXAu9l4bmgZkuVS0wQT+BqnRRhtCKBZhFYDeGIs9IXxoRy/cf9vmiKpxwZ/t6L79V2nMaORWNhBRKovJ8gXg0aeeYVD/5FcgRnz4PuhYifn2y+FuZfUR4rBEd24d5sLIrJcby4drkdaPH6dWeSp+vEwyD5rZoOfdQOQwBoCz/IQ2Tl0r3GS7zAsF2tB5bZ/1t5VCYuWInrSlAmpfxfjLvSi73U8x4SSPS0/N/O0hSm7WP1CGHiYbwWErSPvRusgTsKTb7YwRqsf3L1i7J1pMH2UsN3+JoHu4grqGYe/mFOu1OMakdXpJ/zpQZTdYVSPrTNZ9J0IyiBNywiD1zaTF31g2gyf0tKI5C66722tvuPQ2LkezXCYqMaQQjMLWef4LhJR2p6bdT36Sfk3gdfsf93m0xMRt1ldLebEc9ZDGJARRLqiQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4758.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(451199021)(31696002)(38100700002)(2906002)(31686004)(478600001)(6486002)(6666004)(2616005)(83380400001)(26005)(53546011)(6506007)(6512007)(186003)(86362001)(36756003)(41300700001)(44832011)(316002)(5660300002)(8676002)(8936002)(110136005)(54906003)(6636002)(66556008)(66476007)(4326008)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUxvWnc2MVh2RFBPdTVNYmZxSkNMaTNyRFpBbDBYQ1Fkb01pUVhRblNmUkVk?= =?utf-8?B?dCsxd2Y4ZVMzeGMrajlkSmhNM3l2V1pkb3ZQOFU3aE5GL296SXBoK2VSUkNn?= =?utf-8?B?MWVBZkRMdlpnQ25FKzRmWk9vbVFpOWhRS0pJcTQ2YjFla2l3TnRiOXEzMjZJ?= =?utf-8?B?OGdaM1hkc1dBSzdOZG5iZFk3THFSRDZqcnp1Q2pKVGJnMDJ3cTFFZjlVMWVL?= =?utf-8?B?NTBkalpPZlBxeVNBOVIzaDhVUHJGVUZvelU1MGhpc1pZZ3ZlZ21GaUNQejNL?= =?utf-8?B?L1plb3FlYXFzd2orRnZVRkNLYUpjUk11dkNhSGIyK3NFNUVWOUpEY3ZSNmgx?= =?utf-8?B?dVIwZkpBNEd0ank1WHdTd3djSFgzVmF3YWdWOEtjT0tVVlp5UHlBTGd1Z0FG?= =?utf-8?B?ZUFldFJKbkRUNytTcFZoY2tjcmNJTUp2c0w4SEp0K2NQeG5SckpwL0pCZWlE?= =?utf-8?B?SkxlV0k3MTE1NzNlOWFidGNpLzVKRk9JOStyUmFuVU5EY09qVE1iOUVhamFj?= =?utf-8?B?c2tTWkN6cWFCWFZJNWFnQ3dQbWtpTmxHRlg4bmhrTmxmNDg5ZnJ1clJLa3ha?= =?utf-8?B?S0FiYXRRVU12M2lmT1JKZ1BsTTg2a3Fad2NkZTROYUVEc0ZpamZCdGZpcUFW?= =?utf-8?B?dDgxN2Z4TUp0RVN1YWY3MGFLQVJBcmtwRnFMOWVCUnZwN2RxVy9RWXh5RW5M?= =?utf-8?B?aTArV2Nzak4raHhPRS9EMkZ3eFp1Z3pHYnVEd2lGYTNlY3J5Witjb2dCZ09i?= =?utf-8?B?cEZxNUNYMzMwajg3a3Z2ZlFBQitERVJCL2hwV1NtcXZWVkVpZEgxZVI3VHBN?= =?utf-8?B?TC9lUTRZUzhQQm16VERUY2hudS9oa2tNYXo5bGtoSnV4VmdkV3piTEJaVFBm?= =?utf-8?B?MXcrZ3JHa09Pak5MS3R1eGJHTHNLa1RySHZtdHJxZHBvVjZDSmE3U1dIL2RT?= =?utf-8?B?Ujd0UFJOTU95ZEZMNW9CMXNiL0lKSzh5T1JxWWZpRVNxaG1YbWliYjR1V2Ni?= =?utf-8?B?blRnTzliOFI3ZlYxNkJReW16OTlXUWU1ejhMdG5GVG1ENHM2TUFPTGFNRjJj?= =?utf-8?B?UmhYM25BcG1uejYxU2RDdHNkT21wR2JrcG5TSDJrWnYvREE2dm9Wbm9Fb21m?= =?utf-8?B?K0RZSWw5MjFaSlJ2SWhkVWZTVzJTZlVMOHdGSVl2RHh4ZkY1RitRL2o5ei9H?= =?utf-8?B?a0x6S2p1KzhaSlByamdKUHRIUjFyYm01MVE4blBEbTdvMjJvR2dTUFcvY21O?= =?utf-8?B?dDRoM3Vzemp4bXJMc00xc3NOREZyUUtDazNMRmNTT1dmYVkvYTVRbTgrN0Zy?= =?utf-8?B?Z3g3QWJxV3BRNzFUY29XeGNSNFVPSW1GWEJZNTNCSy83N1dKck5FUkkrTTlH?= =?utf-8?B?RGhHUit2WHY4R0gzT0FmekYwZXBCb2wrbjNLM2trRmEwdTRCelVQQk1UMHNj?= =?utf-8?B?WEZmMmNZVEtjMGhSckdPMC9CYmdaRkJrMmNkbkpnLzZTTUR3QlVEMlVWTGY5?= =?utf-8?B?TlhnWHZPdDdFSEYwME1memM2am5oQVhvakpEbmRYOUFoQXZVZTdzMEt1RVNC?= =?utf-8?B?dFhjRnhCS3JNRlA1b1ZrUjk3bk0xYWc4YlFzeFVXVVJwZUNPb1ZqRVdvaXh4?= =?utf-8?B?bG5CMyswZjUwSy9UQ0J4RDdnWFJTRUhtNEZyS1pDaER3MzVPaVZ2Z2NXVSsv?= =?utf-8?B?dlNNaEQ3N2VoTTRWbGtRNkRhbWNsdGZvYlNMdU5Wdk5UOU1NL3RDRm1kQTRq?= =?utf-8?B?MjVJbVRRY1NVMFhYTkFqZnpPV0R3SHhrY25YRWxrVzBsZldsaGl2RmRxenl3?= =?utf-8?B?Mzc1OHNKQ0hGbStVNEJTdW5MRlFCY3dtNlFHTkdydTN6OUdCTlkxdno4OGJq?= =?utf-8?B?QjhRREdDcEhTdHI5bWZ6dVFQZ0NVdXlyZGFpY2RhN3lIcjVGdHk2c1pDVjMr?= =?utf-8?B?ZlpaVmN5ZDliQmNQdllJdklPOTFHemgvK1JiNnRFM0tSM0FTdDYwOWZSUzdv?= =?utf-8?B?TDRTUkJlUDZoZGhDUFcvYU83RDVUcEhlVGVYb3paOVI2anl2UmMxUVozbTl2?= =?utf-8?B?M1dabnM4cGJyb25PVXV3WlU4OEk0YzJ2VWlCekNuVW5lUEJna2VtdkUxNk1P?= =?utf-8?Q?Eq2vybUPxIxICI/V84iPUoNyR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c64e28be-c372-48d9-9419-08db3f2ceb15 X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 10:17:16.0141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TdGj6W8BMKa2xjVfJkGLJfILKshAq9fLwlZuSMFDogHfXPV9pzpCldNB2OwvB9ev X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4109 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 3/31/23 16:44, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > This reverts commit e09784728689de7949d4cdd559a9590e0bfcc702. The > commit wrongly divides the dummy bytes by dummy bus width to calculate > the dummy bytes. The framework already converts the dummy cycles to the > number of bytes and the controller use the SPI flash command to > determine the dummy cycles via the address width. > > Signed-off-by: Stefan Herbrechtsmeier > > --- > > drivers/spi/zynq_qspi.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c > index 00e3ffcd1d..d1d4048966 100644 > --- a/drivers/spi/zynq_qspi.c > +++ b/drivers/spi/zynq_qspi.c > @@ -676,7 +676,6 @@ static int zynq_qspi_exec_op(struct spi_slave *slave, > const struct spi_mem_op *op) > { > int op_len, pos = 0, ret, i; > - u32 dummy_bytes = 0; > unsigned int flag = 0; > const u8 *tx_buf = NULL; > u8 *rx_buf = NULL; > @@ -689,11 +688,6 @@ static int zynq_qspi_exec_op(struct spi_slave *slave, > } > > op_len = op->cmd.nbytes + op->addr.nbytes + op->dummy.nbytes; > - if (op->dummy.nbytes) { > - op_len = op->cmd.nbytes + op->addr.nbytes + > - op->dummy.nbytes / op->dummy.buswidth; > - dummy_bytes = op->dummy.nbytes / op->dummy.buswidth; > - } > > u8 op_buf[op_len]; > > @@ -707,8 +701,8 @@ static int zynq_qspi_exec_op(struct spi_slave *slave, > pos += op->addr.nbytes; > } > > - if (dummy_bytes) > - memset(op_buf + pos, 0xff, dummy_bytes); > + if (op->dummy.nbytes) > + memset(op_buf + pos, 0xff, op->dummy.nbytes); > > /* 1st transfer: opcode + address + dummy cycles */ > /* Make sure to set END bit if no tx or rx data messages follow */ > -- > 2.30.2 > Ashok: Can you please comment on this one? Thanks, Michal