From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66065C433FE for ; Thu, 6 Oct 2022 13:18:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 86E6984C8D; Thu, 6 Oct 2022 15:17:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1665062279; bh=kBsh/P19UCzeU2xCNkw+2IMx1PJzQgBR0zhF/ldCAVc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HyQCqSFTGq3iJO7Ug1rqSweLqyxuZ+9YFImVCL6FAfBiIQtpG7BwzB/LdesoCD/tR 6fu96CauDcJeoenJLbxF6oQF+RRZd981CWKrWmCBTPVR/J/JCFc2Tr582YOYjaF53e fW1wuLv+UVFkftWDXXWON0JO6b3NDiP4rTJb1nnEpl2tq2Pl9wz500S4GOemZVQGPW OgWGs7DKwCeBM2sybDZIJrTLXzBBW3//Hf+BKBxCmOapSo4lAttNMU62GSUBTAze5s g5SqVSpakw67iomVdXHK7Xj49eVTdHZO+qcJtnynBsFvmLx0Vj8DiXQQRVAPahLxXp Q6vJEKDwGmKXQ== Received: from mail.denx.de (unknown [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: festevam@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id B1FA984C17; Thu, 6 Oct 2022 15:17:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1665062276; bh=kBsh/P19UCzeU2xCNkw+2IMx1PJzQgBR0zhF/ldCAVc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xxFcCDEYkn6EaIGTehp6XsKt6xjelSts0DD6FVlRYH+eWgp7dSpAXcpeezBq/kIcL lLP2qxH5yZwxEqqN91wBsNSJBiFCqNd2D7ZOeT6rPNX2/NKADujI5GJ0shcrLt0W/i +KSAx32w6uJb6n6e2bn63mH2xTtyE9S6PNgW0ttYYeKitSSWpoWTPRtsBJMIGX+pmm 19ypoWmbwZoeFCLSu7nefpvNFdWVy17DFaC+jxeRiTVoRihW4RgKWnc409J/qfNPEi rRIQNAUPmRwpOqN9E/3DBeEy5YhuZkKoF0qKMc32spgFfuAGHfgM+6Q3fMm1/PeSOw WfSOIRFq3+mWA== MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 06 Oct 2022 10:17:56 -0300 From: Fabio Estevam To: Rasmus Villemoes Cc: u-boot@lists.denx.de, Ye Li , Peng Fan , Ying-Chun Liu , Marek Vasut Subject: Re: [PATCH] imx8m: fix reading of DDR4 MR registers [again] In-Reply-To: <20221006125650.1666672-1-rasmus.villemoes@prevas.dk> References: <20221006125650.1666672-1-rasmus.villemoes@prevas.dk> Message-ID: X-Sender: festevam@denx.de User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Rasmus, On 06/10/2022 09:56, Rasmus Villemoes wrote: > Commit 290ffe5788 (imx8m: fix reading of DDR4 MR registers) lifted a > private definition of lpddr4_mr_read() from imx8mm-cl-iot-gate board > code to drivers/ddr/imx/imx8m/ddrphy_utils.c, because that version > actually seems to work in practice. > > However, commit 99c7cc58e1 (ddr: imx: Add i.MX9 DDR controller driver) > reintroduced the broken version in drivers/ddr/imx/imx8m/ddr_init.c, > copied most of the rest of ddrphy_utils.c to > drivers/ddr/imx/phy/ddrphy_utils.c, and stopped building > drivers/ddr/imx/imx8m/ddrphy_utils.c [and that file was then finally > completely removed with 7e9bd84883 (imx8m: ddrphy_utils: Remove unused > file)]. > > I assume this must have broken the imx8mm-cl-iot-gate board, at least > those that have not had their eeprom programmed with the proper > information. It certainly did break our out-of-tree board which always > reads back the ID register and uses that for a sanity check. > > So apply the fix from 290ffe5788 once again. > > Fixes: 99c7cc58e1 (ddr: imx: Add i.MX9 DDR controller driver) > Signed-off-by: Rasmus Villemoes Thanks for the fix: Reviewed-by: Fabio Estevam