From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F4F9C47080 for ; Mon, 31 May 2021 14:36:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82DB561375 for ; Mon, 31 May 2021 14:36:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82DB561375 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 27F8E82E3E; Mon, 31 May 2021 16:36:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DXM5eXtl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8B8D382D62; Mon, 31 May 2021 16:36:47 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E827382D62 for ; Mon, 31 May 2021 16:36:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x735.google.com with SMTP id j184so11372526qkd.6 for ; Mon, 31 May 2021 07:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Gd84j7wcRszt/FFuQB1wEGdgZwg1lcxmDHMISbYv5H0=; b=DXM5eXtldXxlzcRNT26e0r/7+euuwR90kwrJlLE0FFm3+z+9IKLhVue176RQd3OJEZ S95UaJWIx4IrtgwfSft5uvh5FP4n2vDHMQLv2BHh5/f/CduJTpDdrSWFCqDDg0TayKMn SxlWUFIi47qqUF/PeNxKL/Xr/aldIYZGneqxjilqtZ2ZngOXdBsB8cuixmlLwpGvhwSD 1/OqbTCfBCMzxDFqAhnVjRvBAGhwwr7WrehI19VUuY09d4JkeY9T/7/WTJuZbzpZE+We hhn1PMM01M0rypM7i8VOP7hhEYwVqY21GpUYrFm6deQjbXy+/JCFgBOQ495keoQq4V67 8Z0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Gd84j7wcRszt/FFuQB1wEGdgZwg1lcxmDHMISbYv5H0=; b=YlPXLHKaqtoH6dFR/UM+yyh+E6ghgnFcV3WMzGAQu/JGVwAactmiS6sPUEPET2sCsT Cr6zi+TmGHNNU9BukDH3Qwr2qbgRLkczcZUethUq42oMC8YvaPnWsd+jHHuTNQy2aDHZ 4QikBfjLbcEd1wgbnz8pg5qErfPtSMfmng2gOisEDzlFsep4EyJoyupo8NEz8LfhCM9c T4eLTtakGhmx4zw6YfP9tYxcdhAUamBWUXtEhHXf33aJiKFvX7kEBoh42OthLMO1D6Y+ yQHdM++BCJCaL2ywTAdd7BMOk4JmkxTvy/w5U3mPFSgr8Z9FhWyiew5kchq42R7A72NT 0uoA== X-Gm-Message-State: AOAM5317X+SOrPXn/0SmvJWxF0Hh/MtQnL9iPDIgfkgQNBfDQAIfxm39 e9mFyYAYvuvllktudzDCchE= X-Google-Smtp-Source: ABdhPJwDigqai/qajsJxJ9qbwCLswR8JVHv6QJsLk34XV8yrR3Q6F9N9l6yUy9gKI2+qn1A6hyneyA== X-Received: by 2002:a37:5847:: with SMTP id m68mr16553681qkb.111.1622471798670; Mon, 31 May 2021 07:36:38 -0700 (PDT) Received: from [192.168.1.201] (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.googlemail.com with ESMTPSA id y10sm8530855qtm.17.2021.05.31.07.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 May 2021 07:36:38 -0700 (PDT) Subject: Re: [[PATCH] colibri_imx6: add board_fit_config_name_match to support FIT in SPL To: liu.ming50@gmail.com, u-boot@lists.denx.de Cc: sergio.prado@toradex.com, max.krummenacher@toradex.com, marcel.ziswiler@toradex.com References: <20210531070620.6780-1-liu.ming50@gmail.com> From: Sean Anderson Message-ID: Date: Mon, 31 May 2021 10:36:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210531070620.6780-1-liu.ming50@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 5/31/21 3:06 AM, liu.ming50@gmail.com wrote: > From: Ming Liu > > Only one dtb is currently supported, so match with imx6-colibri. > > Signed-off-by: Ming Liu > --- > board/toradex/colibri_imx6/colibri_imx6.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/board/toradex/colibri_imx6/colibri_imx6.c b/board/toradex/colibri_imx6/colibri_imx6.c > index c0e7754469..587d92a8e9 100644 > --- a/board/toradex/colibri_imx6/colibri_imx6.c > +++ b/board/toradex/colibri_imx6/colibri_imx6.c > @@ -1081,6 +1081,16 @@ void board_init_f(ulong dummy) > board_init_r(NULL, 0); > } > > +#ifdef CONFIG_SPL_LOAD_FIT > +int board_fit_config_name_match(const char *name) > +{ > + if (!strcmp(name, "imx6-colibri")) > + return 0; > + > + return -1; Please use an errno. > +} > +#endif > + > void reset_cpu(void) > { > } > Do you need to match "imx6-colibri", or could you use the default config? --Sean