From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 22/26 v6] spl: spl_legacy: Add cache flush after reading U-Boot image
Date: Thu, 9 Apr 2020 09:29:48 +0200 [thread overview]
Message-ID: <f7cc3f94-7b18-46fc-6c5b-b3abf3a4e0fa@gmail.com> (raw)
In-Reply-To: <20200408080942.7694-23-sr@denx.de>
Am 08.04.2020 um 10:09 schrieb Stefan Roese:
> From: Weijie Gao <weijie.gao@mediatek.com>
>
> Flush the cache after reading of the U-Boot proper into SDRAM so that
> it can be started.
>
> This is needed on some platforms, e.g. MT76x8.
>
> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Weijie Gao <weijie.gao@mediatek.com>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> ---
> Changes in v6:
> - New patch
>
> common/spl/spl_legacy.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/common/spl/spl_legacy.c b/common/spl/spl_legacy.c
> index 2cd2a74a4c..e320206098 100644
> --- a/common/spl/spl_legacy.c
> +++ b/common/spl/spl_legacy.c
> @@ -4,6 +4,7 @@
> */
>
> #include <common.h>
> +#include <cpu_func.h>
> #include <malloc.h>
> #include <spl.h>
>
> @@ -108,5 +109,8 @@ int spl_load_legacy_img(struct spl_image_info *spl_image,
> return -EINVAL;
> }
>
> + /* Flush cache of loaded U-Boot image */
> + flush_cache((unsigned long)spl_image->load_addr, spl_image->size);
> +
I failed to find the mail, but haven't we discussed moving this cache
flush to your arch before starting a binary?
I cannot see this being required or implemented for non-legacy images,
and it still seems wrong here.
Regards,
Simon
> return 0;
> }
>
next prev parent reply other threads:[~2020-04-09 7:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 8:09 [PATCH 00/26 v6] Refactor the architecture parts of mt7628 Stefan Roese
2020-04-08 8:09 ` [PATCH 01/26 v6] mips: add support to restore exception vector base before booting linux Stefan Roese
2020-04-08 8:09 ` [PATCH 02/26 v6] mips: mtmips: add predefined i-cache/d-cache size and linesize Stefan Roese
2020-04-08 8:09 ` [PATCH 03/26 v6] mips: add an option to support initialize SRAM for initial stack Stefan Roese
2020-04-08 8:09 ` [PATCH 04/26 v6] mips: start.S: avoid overwriting outside gd when clearing global data in stack Stefan Roese
2020-04-08 8:09 ` [PATCH 05/26 v6] sysreset: add reset controller based reboot driver Stefan Roese
2020-04-08 8:09 ` [PATCH 06/26 v6] mips: mtmips: make use of sysreset-resetctrl for mt7628 soc Stefan Roese
2020-04-08 8:09 ` [PATCH 07/26 v6] configs: enable CONFIG_RESTORE_EXCEPTION_VECTOR_BASE for all mtmips boards Stefan Roese
2020-04-08 8:09 ` [PATCH 08/26 v6] mips: add a mtmips-specific field to architecture-specific global data Stefan Roese
2020-04-08 8:09 ` [PATCH 09/26 v6] mips: add a option to support not reserving malloc space on initial stack Stefan Roese
2020-04-08 8:09 ` [PATCH 10/26 v6] mips: mtmips: rewrite lowlevel codes of mt7628 Stefan Roese
2020-04-08 8:09 ` [PATCH 11/26 v6] dts: mtmips: add alternative pinmux node for uart2 Stefan Roese
2020-04-08 8:09 ` [PATCH 12/26 v6] mips: enable support for appending dtb to spl binary Stefan Roese
2020-04-08 8:09 ` [PATCH 13/26 v6] mips: add an option to enable u_boot_list section for SPL loaders in u-boot-spl.lds Stefan Roese
2020-04-08 8:09 ` [PATCH 14/26 v6] lib: enable lzma decompression support for SPL build Stefan Roese
2020-04-08 8:09 ` [PATCH 15/26 v6] Makefile: add support to generate LZMA compressed u-boot image Stefan Roese
2020-04-08 8:09 ` [PATCH 16/26 v6] tools: binman: add etype file for u-boot-lzma-img Stefan Roese
2020-04-08 8:09 ` [PATCH 17/26 v6] spl: Extract legacy image handling into separate file Stefan Roese
2020-04-08 8:09 ` [PATCH 18/26 v6] spl: spl_legacy: Use IS_ENABLED() to remove #ifdef Stefan Roese
2020-04-08 8:09 ` [PATCH 19/26 v6] spl: spl_nor: Copy image header to local struct Stefan Roese
2020-04-09 7:24 ` Simon Goldschmidt
2020-04-08 8:09 ` [PATCH 20/26 v6] spl: spl_nor: Move legacy image loading into spl_legacy.c Stefan Roese
2020-04-09 18:51 ` Daniel Schwierzeck
2020-04-10 8:02 ` Stefan Roese
2020-04-08 8:09 ` [PATCH 21/26 v6] spl: spl_legacy: Add lzma decompression support for legacy image Stefan Roese
2020-04-08 8:09 ` [PATCH 22/26 v6] spl: spl_legacy: Add cache flush after reading U-Boot image Stefan Roese
2020-04-09 7:29 ` Simon Goldschmidt [this message]
2020-04-09 7:43 ` Stefan Roese
2020-04-09 16:47 ` Daniel Schwierzeck
2020-04-10 7:50 ` Stefan Roese
2020-04-09 18:15 ` Simon Goldschmidt
2020-04-08 8:09 ` [PATCH 23/26 v6] mips: mtmips: add SPL support Stefan Roese
2020-04-08 8:09 ` [PATCH 24/26 v6] mips: mtmips: enable SPL for all boards Stefan Roese
2020-04-08 8:09 ` [PATCH 25/26 v6] mips: mtmips: add support for mt7628-rfb Stefan Roese
2020-04-08 8:09 ` [PATCH 26/26 v6] mips: mtmips: Increase CONFIG_SPL_SYS_MALLOC_F_LEN Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7cc3f94-7b18-46fc-6c5b-b3abf3a4e0fa@gmail.com \
--to=simon.k.r.goldschmidt@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox