public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, git@amd.com, xypron.glpk@gmx.de,
	ilias.apalodimas@linaro.org, sjg@chromium.org,
	Casey Connolly <casey.connolly@linaro.org>,
	Kory Maincent <kory.maincent@bootlin.com>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Padmarao Begari <padmarao.begari@amd.com>,
	Sughosh Ganu <sughosh.ganu@arm.com>,
	Weijie Gao <weijie.gao@mediatek.com>, Yao Zi <me@ziyao.cc>
Subject: Re: [PATCH v2 0/3] fwu: Call EFI stack initialization after preboot
Date: Tue, 31 Mar 2026 16:46:48 +0200	[thread overview]
Message-ID: <f82159b5-2e5d-4412-b946-e87d458e76fe@amd.com> (raw)
In-Reply-To: <20260331142806.GA1235458@bill-the-cat>



On 3/31/26 16:28, Tom Rini wrote:
> On Wed, Mar 18, 2026 at 02:25:08PM +0100, Michal Simek wrote:
> 
>> Hi,
>>
>> the whole series is trying to address issues we have on platforms where usb
>> and ufs init are not done before efi initialization. This is happenin on
>> platforms where A/B update is enabled. FWU code is called early and do EFI
>> initialization before usb and ufs started that's why they are not visible.
>>
>> We are workarounding it by starting usb/ufs from board file but this should
>> be more generic approach.
> 
> This doesn't build on current next:
> https://source.denx.de/u-boot/u-boot/-/jobs/1416493#L1001
> common/event.c:56:1: error: static assertion failed: "event type_name size"
>     56 | _Static_assert(ARRAY_SIZE(type_name) == EVT_COUNT, "event type_name size");
>        | ^~~~~~~~~~~~~~
> make[2]: *** [scripts/Makefile.build:271: common/event.o] Error 1
> make[1]: *** [Makefile:2201: common] Error 2
> make[1]: *** Waiting for unfinished jobs....
> 

I am able to replicate. Will send v3 with fixing this.

diff --git a/common/event.c b/common/event.c
index 8d7513eb10b6..936d5e36d691 100644
--- a/common/event.c
+++ b/common/event.c
@@ -49,6 +49,9 @@ const char *const type_name[] = {
         /* main loop events */
         "main_loop",

+       /* post preboot events */
+       "post preboot",
+
         /* livetree has been built */
         "of_live_init",
  };

Thanks,
Michal

  reply	other threads:[~2026-03-31 14:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 13:25 [PATCH v2 0/3] fwu: Call EFI stack initialization after preboot Michal Simek
2026-03-18 13:25 ` [PATCH v2 1/3] event: Check return value from event_notify_null() Michal Simek
2026-03-19 22:09   ` Simon Glass
2026-03-18 13:25 ` [PATCH v2 2/3] event: Introduce EVT_POST_PREBOOT event Michal Simek
2026-03-19 22:09   ` Simon Glass
2026-03-18 13:25 ` [PATCH v2 3/3] fwu: Move boottime checks to EVT_POST_PREBOOT Michal Simek
2026-03-19 23:56 ` [PATCH v2 0/3] fwu: Call EFI stack initialization after preboot Casey Connolly
2026-03-20  8:31   ` Michal Simek
2026-03-31 14:28 ` Tom Rini
2026-03-31 14:46   ` Michal Simek [this message]
2026-03-31 15:00   ` Heinrich Schuchardt
2026-03-31 15:03     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f82159b5-2e5d-4412-b946-e87d458e76fe@amd.com \
    --to=michal.simek@amd.com \
    --cc=casey.connolly@linaro.org \
    --cc=git@amd.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kory.maincent@bootlin.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=me@ziyao.cc \
    --cc=padmarao.begari@amd.com \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@arm.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=weijie.gao@mediatek.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox