public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] cmd: add bootslot command to select/boot slot based on boot counts
Date: Fri, 24 Aug 2018 13:13:28 +0200	[thread overview]
Message-ID: <f9ef3ce0-671c-e8a3-dd4c-e720c6d39fe5@prevas.dk> (raw)
In-Reply-To: <93b97bb7-cf31-80c5-e0c1-c29eb2db9c47@geanix.com>

>> With RAUC bootslot's is specified with uppercase letters, uppercase is 
>> not preserved.
>> We end up with BOOT_b_LEFT=2...
>> botocmd_* is with lowercase, just to make things easier.
> 
> I cannot reproduce the lowercase issue. Can you send me your (def)config 
> and environment?
> 
> % grep BOOTSLOT .config
> CONFIG_CMD_BOOTSLOT=y
> CONFIG_CMD_BOOTSLOT_ENV_SLOTS="BOOTORDER"
> CONFIG_CMD_BOOTSLOT_ENV_COUNT="BOOT_%s_LEFT"
> CONFIG_CMD_BOOTSLOT_ENV_CMD="BOOTCMD_%s"
> CONFIG_CMD_BOOTSLOT_DEFAULT_COUNT=3
> 
> % grep -i boot board/raspberrypi/rpi/env.txt
> BOOTORDER=A B
> bootargs_all=console=ttyS0,115200n8 rootfstype=squashfs rootwait
> bootargs_a=root=/dev/mmcblk0p2 bootslot=A
> bootargs_b=root=/dev/mmcblk0p3 bootslot=B
> set_bootargs_a=setenv bootargs $bootargs_all $bootargs_a
> set_bootargs_b=setenv bootargs $bootargs_all $bootargs_b
> bootcmd_common=run load_kernel; booti $loadaddr - $fdtcontroladdr
> BOOTCMD_A=run set_bootargs_a bootcmd_common
> BOOTCMD_B=run set_bootargs_b bootcmd_common
> bootcmd=bootslot boot

Hi,

I'm not able to reproduce the lowercase issue, I must have got the 
config wrong :-)

Please submit a [PATCH] for this as it could be very useful.

/Sean

  reply	other threads:[~2018-08-24 11:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 12:34 [U-Boot] [RFC] cmd: add bootslot command to select/boot slot based on boot counts Martin Hundebøll
2018-07-16  6:05 ` Sean Nyekjær
2018-07-30 20:45   ` Martin Hundebøll
2018-08-24 11:13     ` Sean Nyekjær [this message]
2019-12-11  8:16 ` Sean Nyekjaer
2020-02-16 15:33 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9ef3ce0-671c-e8a3-dd4c-e720c6d39fe5@prevas.dk \
    --to=sean.nyekjaer@prevas.dk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox