Re: [PATCH v2 3/7] drivers: misc: k3_avs: Check return code while programming AVS

["Kumar, Udit" <u-kumar1@ti.com>]

On 5/28/2024 1:43 PM, Manorit Chawdhry wrote:
> Check if AVS could not be programmed and print a warning.
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> ---
>   drivers/misc/k3_avs.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/k3_avs.c b/drivers/misc/k3_avs.c
> index a0d7bb7595b3..d9037b4512c6 100644
> --- a/drivers/misc/k3_avs.c
> +++ b/drivers/misc/k3_avs.c
> @@ -489,7 +489,10 @@ static int k3_avs_probe(struct udevice *dev)
>   		if (vd->flags & VD_FLAG_INIT_DONE)
>   			continue;
>   
> -		k3_avs_program_voltage(priv, vd, vd->opp);
> +		ret = k3_avs_program_voltage(priv, vd, vd->opp);
> +		if (ret)
> +			dev_warn(dev, "Could not program AVS voltage for VD%d\n",
> +				 vd->id);

Could you extend print with vd->opp as well.

With this change

Reviewed-by: Udit Kumar <u-kumar1@ti.com>

>   	}
>   
>   	if (!device_is_compatible(priv->dev, "ti,am654-avs"))
>