From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92399C36010 for ; Fri, 11 Apr 2025 07:28:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C826C83EBA; Fri, 11 Apr 2025 09:28:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="TN0Z821S"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A123383EE2; Fri, 11 Apr 2025 09:28:10 +0200 (CEST) Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 88D3183E78 for ; Fri, 11 Apr 2025 09:28:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=6196a1474a=patrice.chotard@foss.st.com Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53B2pxYN005418; Fri, 11 Apr 2025 09:27:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= wGhkrdElYTVJfT+bVO9EDkCrEWwv3l//900VI2ZTRRk=; b=TN0Z821S2qenJt3I lv4BHK1xDprlUe9e2FWzl2OGUZrgDSzdEd1PCxgPJJg7yr1HcYEZyMk9fGmIaq1a i/pwIu0lxboSy1oeDPEo50oj6mNAMGnSzLWMvvv2xyYWgy+Q1YtUoaGE9z7aQ0cY nKpmhihWPnglRK37RoIsHFWBSSg1/u/rGne3S4ZXL3fuz8K9nFz6HzybwXjNH8xX /nwo051WXc9rtLcQ5rX5XLssfHa63wtedbJIyqL98t7V3MyymhdYQH2IZvyjyIN9 Nisu7ziX2Iq5yuHM2MRHsM3jfLG1w1F0/jerKe2A+6duG2vltV6vkS0qjpoK7Thc YsNVGA== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 45uffn21y7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Apr 2025 09:27:54 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 3773A4002D; Fri, 11 Apr 2025 09:26:23 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1FD634ED60B; Fri, 11 Apr 2025 09:24:14 +0200 (CEST) Received: from [10.252.25.37] (10.252.25.37) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 11 Apr 2025 09:24:13 +0200 Message-ID: Date: Fri, 11 Apr 2025 09:24:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH 2/2] ARM: stm32: env: Enable scan and start for AB schema on STM32MP15 DHSOM To: Pascal Zimmermann , CC: Marek Vasut , Patrick Delaunay , Tom Rini , Simon Glass , , References: <20250327143843.19358-1-pzimmermann@dh-electronics.com> <20250327143843.19358-3-pzimmermann@dh-electronics.com> Content-Language: en-US From: Patrice CHOTARD In-Reply-To: <20250327143843.19358-3-pzimmermann@dh-electronics.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.252.25.37] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-11_02,2025-04-10_01,2024-11-22_01 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 3/27/25 15:38, Pascal Zimmermann wrote: > For the STM32MP15 DHSOM, change the default environment so an AB schema > on a device can be detected. > > For this the define "SCAN_DEV_FOR_BOOT_PARTS" is overwritten and > appended. > > The detection works by looking for the partitions with specific lables. > The name of those partitions are in the variables and its defaults: > * dh_ab_partname_primary=rootfs-a > * dh_ab_partname_secondary=rootfs-b > > To prevent being hanging at bootcmd, enable "CONFIG_BOOT_RETRY" and > "CONFIG_RESET_TO_RETRY", but the timer will only be activated, if the AB > partitions are detected. > > Signed-off-by: Pascal Zimmermann > --- > Cc: Marek Vasut > Cc: Patrick Delaunay > Cc: Patrice Chotard > Cc: Tom Rini > Cc: Simon Glass > Cc: u-boot@dh-electronics.com > Cc: uboot-stm32@st-md-mailman.stormreply.com > Cc: u-boot@lists.denx.de > --- > configs/stm32mp15_dhsom.config | 3 +++ > include/configs/stm32mp15_dh_dhsom.h | 33 ++++++++++++++++++++++++++++ > 2 files changed, 36 insertions(+) > > diff --git a/configs/stm32mp15_dhsom.config b/configs/stm32mp15_dhsom.config > index 7e5b5aa67ef..c84116482f6 100644 > --- a/configs/stm32mp15_dhsom.config > +++ b/configs/stm32mp15_dhsom.config > @@ -10,6 +10,9 @@ CONFIG_BOARD_EARLY_INIT_F=y > CONFIG_BOARD_SIZE_LIMIT=1441792 > CONFIG_BOOTCOUNT_BOOTLIMIT=3 > CONFIG_BOOTDELAY=1 > +CONFIG_BOOTRETRY=y > +CONFIG_RESET_TO_RETRY=y > +CONFIG_BOOT_RETRY_TIME=-1 > CONFIG_CMD_ADC=y > CONFIG_CMD_REMOTEPROC=y > CONFIG_CMD_STBOARD=y > diff --git a/include/configs/stm32mp15_dh_dhsom.h b/include/configs/stm32mp15_dh_dhsom.h > index c004a8cec82..267e3446779 100644 > --- a/include/configs/stm32mp15_dh_dhsom.h > +++ b/include/configs/stm32mp15_dh_dhsom.h > @@ -17,7 +17,40 @@ > " 0x800000\0" > #endif > > +/* Add the search for AB partitons */ > +#define SCAN_DEV_FOR_BOOT_PARTS \ > + "run dh_check_if_ab; " \ > + "if test -z \"${devplist}\"; " \ > + "then " \ > + "part list ${devtype} ${devnum} -bootable devplist; " \ > + "fi; " > + > #define STM32MP_BOARD_EXTRA_ENV \ > + "altbootcmd= " \ > + "setenv dh_ab_get_partnames " \ > + "'setenv dh_ab_partnames ${dh_ab_partname_secondary} " \ > + "${dh_ab_partname_primary}' && " \ > + "run bootcmd\0" \ > + "dh_check_if_ab= " /* Sets devplist if AB partitions*/ \ > + "echo test for AB on ${devtype} ${devnum} && " \ > + "run dh_ab_get_partnames && " \ > + "setenv devplist && " \ > + "for partname in ${dh_ab_partnames}; do " \ > + "setenv partnum && " \ > + "if part number ${devtype} ${devnum} ${partname} partnum; "\ > + "then " \ > + "setenv devplist \"${devplist} ${partnum}\" && "\ > + "setenv bootretry 60 ;" \ > + "fi; " \ > + "done ; " \ > + "if test -n \"${devplist}\"; " \ > + "then echo AB partitions found! ; " \ > + "fi\0" \ > + "dh_ab_get_partnames= " /* Sets dh_ab_partnames */ \ > + "setenv dh_ab_partnames ${dh_ab_partname_primary} " \ > + "${dh_ab_partname_secondary}\0" \ > + "dh_ab_partname_primary=rootfs-a\0" /* Names of AB partitions */\ > + "dh_ab_partname_secondary=rootfs-b\0" \ > "dh_preboot=" \ > "run dh_testbench_backward_compat\0" \ > "dh_update_sd_to_emmc=" /* Install U-Boot from SD to eMMC */ \ Reviewed-by: Patrice Chotard Thanks Patrice