Re: [PATCH v2 3/7] tools: add mkmbn tool for Qualcomm

[Casey Connolly <casey.connolly@linaro.org>]

Hi Stephan

On 6/4/25 11:15, Stephan Gerhold wrote:
> On Mon, Jun 02, 2025 at 06:10:54PM +0200, Casey Connolly wrote:
>> This is a fork of qtestsign[1] with modifications to integrate with the
>> U-Boot build system.
> 
> I think it would be good if the "library" part of qtestsign (cert.py,
> elf.py, hashseg.py) would stay unmodified if possible, and you only add
> a new frontend on top (mkmbn.py). This would simplify syncing upstream
> changes in the future, e.g. should the v7 support get introduced at some
> point.

Ack, I thought about this but way too late...>
> Have you changed anything meaningful inside these three files? Copying
> the original files back in I mostly see re-formatting at the moment,
> which makes it hard to see what is different.

Yes, I made some changes so that I can construct an ELF header out of 
thin air, since the original code only lets you parse one from a file.

Sucks about the formatting changes, not sure when that happened.

I will open a PR to qtestsign adding the features I need so hopefully we 
can keep them aligned.

> 
> Thanks,
> StephanKind regards,

-- 
Casey (she/they)