public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v8 5/7] arm: socfpga: Update DE1 environment
Date: Mon, 30 Jan 2017 16:07:10 +0100	[thread overview]
Message-ID: <fbb64982-666e-eaf4-6664-ad628bec2301@suse.de> (raw)
In-Reply-To: <1485644718-20435-6-git-send-email-dwesterg@gmail.com>

On 01/29/2017 12:05 AM, Dalon Westergreen wrote:
> From: Dalon Westergreen <dalon.westergreen@intel.com>
>
> Remove the default environment as it is now in a common
> header.
>
> Add the CONFIG_DEFAULT_DEVICE_TREE to the board's defconfig
> to set the linux devicetree name.
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
> Acked-by: Marek Vasut <marex@denx.de>
> Acked-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
>   configs/socfpga_de1_soc_defconfig |  1 +
>   include/configs/socfpga_de1_soc.h | 19 +------------------
>   2 files changed, 2 insertions(+), 18 deletions(-)
>
> diff --git a/configs/socfpga_de1_soc_defconfig b/configs/socfpga_de1_soc_defconfig
> index 032deef..d78e8a1 100644
> --- a/configs/socfpga_de1_soc_defconfig
> +++ b/configs/socfpga_de1_soc_defconfig
> @@ -6,6 +6,7 @@ CONFIG_TARGET_SOCFPGA_TERASIC_DE1_SOC=y
>   CONFIG_SPL_STACK_R_ADDR=0x00800000
>   CONFIG_SPL_YMODEM_SUPPORT=y
>   CONFIG_DEFAULT_DEVICE_TREE="socfpga_cyclone5_de1_soc"
> +CONFIG_DEFAULT_FDT_FILE="socfpga_cyclone5_de1_soc.dtb"
>   CONFIG_FIT=y
>   CONFIG_SYS_CONSOLE_IS_IN_ENV=y
>   CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
> diff --git a/include/configs/socfpga_de1_soc.h b/include/configs/socfpga_de1_soc.h
> index deec647..3142bd1 100644
> --- a/include/configs/socfpga_de1_soc.h
> +++ b/include/configs/socfpga_de1_soc.h
> @@ -18,7 +18,7 @@
>   #define PHYS_SDRAM_1_SIZE		0x40000000	/* 1GiB */
>   
>   /* Booting Linux */
> -#define CONFIG_BOOTFILE		"fitImage"
> +#define CONFIG_BOOTFILE		"zImage"

ok, here you're confusing me. I thought the point of having the crude, 
hacky mmcload/mmcboot in bootcmd was because you want to be legacy 
compatible. If you're changing the bootfile name, that point is moot.

So at this point, why not just switch to distro boot and extlinux.conf / 
efi altogether?


Alex

  reply	other threads:[~2017-01-30 15:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-28 23:05 [U-Boot] [PATCH v8 0/7] arm: socfpga: update default u-boot environment Dalon Westergreen
2017-01-28 23:05 ` [U-Boot] [PATCH v8 1/7] arm: socfpga: add env settings to common header Dalon Westergreen
2017-01-30 14:55   ` Alexander Graf
2017-01-30 15:11     ` Dalon Westergreen
2017-01-30 15:14       ` Alexander Graf
2017-01-28 23:05 ` [U-Boot] [PATCH v8 2/7] arm: socfpga: update de0 nano default environment Dalon Westergreen
2017-01-30 15:04   ` Alexander Graf
2017-01-28 23:05 ` [U-Boot] [PATCH v8 3/7] arm: socfpga: update cyclone5 socdk " Dalon Westergreen
2017-01-28 23:05 ` [U-Boot] [PATCH v8 4/7] arm: socfpga: update arria5 " Dalon Westergreen
2017-01-28 23:05 ` [U-Boot] [PATCH v8 5/7] arm: socfpga: Update DE1 environment Dalon Westergreen
2017-01-30 15:07   ` Alexander Graf [this message]
2017-01-30 15:17     ` Westergreen, Dalon
2017-01-28 23:05 ` [U-Boot] [PATCH v8 6/7] arm: socfpga: Update SoCKit environment Dalon Westergreen
2017-01-28 23:05 ` [U-Boot] [PATCH v8 7/7] arm: socfpga: Update sr1500 environment Dalon Westergreen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbb64982-666e-eaf4-6664-ad628bec2301@suse.de \
    --to=agraf@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox