public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Patrick DELAUNAY <patrick.delaunay@foss.st.com>
To: u-boot@lists.denx.de
Subject: [PATCH 03/15] dm: gpio: Rename get_dir_flags() method to get_flags()
Date: Thu, 21 Jan 2021 10:02:55 +0100	[thread overview]
Message-ID: <fbd0b77a-93fa-d7ef-a6ea-ae92b846cb4a@foss.st.com> (raw)
In-Reply-To: <20210115140500.846307-4-sjg@chromium.org>

Hi Simon,

On 1/15/21 3:04 PM, Simon Glass wrote:
> It is more useful to be able to read all the flags, not just the direction
> ones. In fact this is what the STM32 driver does. Update the method name
> to reflect this.
>
> Tweak the docs a little and use 'flagsp' as the return argument, as is
> common in driver model, to indicate it returns a value.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   drivers/gpio/gpio-uclass.c      | 30 +++++++++++++++---------------
>   drivers/gpio/sandbox.c          |  8 ++++----
>   drivers/gpio/stm32_gpio.c       |  8 ++++----
>   drivers/pinctrl/pinctrl-stmfx.c |  8 ++++----
>   include/asm-generic/gpio.h      | 13 +++++++------
>   5 files changed, 34 insertions(+), 33 deletions(-)
>

Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks

Patrick

  parent reply	other threads:[~2021-01-21  9:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 14:04 [PATCH 00/15] gpio: Update and simplify the uclass API Simon Glass
2021-01-15 14:04 ` [PATCH 01/15] gpio: Disable functions not used with of-platdata Simon Glass
2021-01-18 21:17   ` Pratyush Yadav
2021-01-21  8:59   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 02/15] dm: gpio: Rename set_dir_flags() method to update_flags() Simon Glass
2021-01-18 21:39   ` Pratyush Yadav
2021-01-21  9:01   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 03/15] dm: gpio: Rename get_dir_flags() method to get_flags() Simon Glass
2021-01-18 21:54   ` Pratyush Yadav
2021-01-21  9:02   ` Patrick DELAUNAY [this message]
2021-01-15 14:04 ` [PATCH 04/15] gpio: Rename dm_gpio_get_dir_flags() to dm_gpio_get_flags() Simon Glass
2021-01-18 21:57   ` Pratyush Yadav
2021-01-21  9:05   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 05/15] gpio: Drop dm_gpio_set_dir() Simon Glass
2021-01-21  9:06   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 06/15] gpio: sandbox: Rename GPIO dir_flags to flags Simon Glass
2021-01-21  9:14   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 07/15] gpio: sandbox: Use a separate flag for the value Simon Glass
2021-01-21  9:33   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 08/15] gpio: sandbox: Fully separate pin value from output value Simon Glass
2021-01-21  9:39   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 09/15] gpio: sandbox: Make sandbox_gpio_set_flags() set all flags Simon Glass
2021-01-21  9:43   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 10/15] dm: gpio: Add a way to update flags Simon Glass
2021-01-21 10:07   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 11/15] gpio: Replace direction_input() and direction_output() Simon Glass
2021-01-21 10:12   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 12/15] gpio: Use an 'ops' variable everywhere Simon Glass
2021-01-21 10:13   ` Patrick DELAUNAY
2021-01-15 14:04 ` [PATCH 13/15] gpio: x86: Drop the deprecated methods in intel_gpio Simon Glass
2021-01-15 14:04 ` [PATCH 14/15] gpio: sandbox: Track whether a GPIO is driven Simon Glass
2021-01-21 10:19   ` Patrick DELAUNAY
2021-01-15 14:05 ` [PATCH 15/15] gpio: Add a way to read 3-way strapping pins Simon Glass
2021-01-21 10:52   ` Patrick DELAUNAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbd0b77a-93fa-d7ef-a6ea-ae92b846cb4a@foss.st.com \
    --to=patrick.delaunay@foss.st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox