Re: [PATCH v5 4/4] configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMER

[<Eugen.Hristev@microchip.com>]

On 3/7/22 3:06 PM, Claudiu Beznea - M18063 wrote:
> On 07.03.2022 13:10, Clément Léger wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Le Mon, 7 Mar 2022 11:06:17 +0000,
>> <Claudiu.Beznea@microchip.com> a écrit :
>>
>>>> diff --git a/configs/sama5d2_icp_mmc_defconfig b/configs/sama5d2_icp_mmc_defconfig
>>>> index 7761a57e0c..2eb2e92110 100644
>>>> --- a/configs/sama5d2_icp_mmc_defconfig
>>>> +++ b/configs/sama5d2_icp_mmc_defconfig
>>>> @@ -83,5 +83,6 @@ CONFIG_ATMEL_USART=y
>>>>   CONFIG_TIMER=y
>>>>   CONFIG_SPL_TIMER=y
>>>>   CONFIG_ATMEL_PIT_TIMER=y
>>>> +CONFIG_ATMEL_TCB_TIMER=y
>>>
>>> As far as I can tell, dm_timer_init() will probe the first available timer
>>> if there is no CONFIG_OF_REAL enabled + tick-timer DT entry. With this,
>>> having 2 timers enabled in config might not lead to using TCB all the time
>>> as it might be expected.
>>
>> Hi Claudiu,
>>
>> Hum indeed. Should I remove this commit and let the user select the TCB
>> when needed ?
> 
> I would select only one timer in config to be able to work also with Linux
> DT (if any) as in Linux SAMA5D2 works with TCB as the active/prefered
> clocksource/clockevent so it is already available in DT. Eugen, is this OK?

Hi,

In defconfig you are free to select which driver you want to build. 
(both, only one, or none).
In DT, you have to describe the board and SoC as in Linux.

> 
> Thank you,
> Claudiu Beznea
> 
>>
>> Thanks,
>>
>>>
>>> Thank you,
>>> Claudiu Beznea
>>
>>
>> --
>> Clément Léger,
>> Embedded Linux and Kernel engineer at Bootlin
>> https://bootlin.com
>