From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFFCBC352A1 for ; Tue, 6 Dec 2022 12:21:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2725B852A2; Tue, 6 Dec 2022 13:21:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HcU1mq95"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B299B8527F; Tue, 6 Dec 2022 13:21:39 +0100 (CET) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2112A852A2 for ; Tue, 6 Dec 2022 13:21:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel.schwierzeck@gmail.com Received: by mail-ej1-x633.google.com with SMTP id ud5so5766823ejc.4 for ; Tue, 06 Dec 2022 04:21:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CoAjxr5z0Vb3muzcCePb/z9kwmzft+OgRjEJj4kFIOU=; b=HcU1mq957IjkcZDJVrhe0+1adW0NlcawYPzWnjjODzgJ2l/ZK2YuUG3VbV7hNxJcK7 7nSy412Uqh0WqcITOSLhADBMvSUvACNipXN4N9nTvvbh8hyta8OS16RmYvVlCtcEqc6J kWJ/IsCshfPC8xShhc96k3m/KeUuUPXpaFJQ4Y+TDm22Cg8VQm1uG8XggtbiJhZgVKrX rftH6dIod2s3ujB6T2FvJztLMh4F93raFkJi923+BIZZP0ei9TI1Yijy7IjKmfi/6ioW Y9asDhhGIz5iGRs6lXm+BbP1s3+9Wpo8QIIl0snm/rDHCLR2AWy6vL5I3c9coDFe+GOh LXmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CoAjxr5z0Vb3muzcCePb/z9kwmzft+OgRjEJj4kFIOU=; b=IuqD7ZZhCanV04TQ+ihL8BLvvqc4oGpuIvDZ2er9N16GxiGdGVFWd/oko9ZPv+z2ak +P4OVnXlfSQi9UiGNFObjc2HR7ft8HjA9nSJ/nXu+zG6MNxO2L4e5AnUEeJDg0z6GQaJ P6g/DhGqzui+90fR0BgI/KFBGsMkcgJVuHgYtRjcMULiRnko40vZm853Kn9wfKFdInm7 7ak1fmSfb0xGklxCbkHu/QXEhgvf74Nm8xRIdByI+prH99VeWhuH6ExH4yI7k/yvW3oc Qd/V4HJnWDqZP+/HCnW4rBKXb+STyIpYc4zkiD2312MnEXzTwdOcZ+HwNzg1gmDhqYbK AHsQ== X-Gm-Message-State: ANoB5pkwWa7iRUa3Kkesf/3UkP/mKV9AE2tK8vJvaSsk5xg8s0jvMvaM 8UexVjeeF4paCUkgj+kmp68= X-Google-Smtp-Source: AA0mqf4MGCy+JWyQ7zEYUdXtTzLHgvv1dffPfviA8cOadn5GvJIpReiVoDGBwk40bwOyN/1kohGdLA== X-Received: by 2002:a17:906:814e:b0:7c0:d7b0:fbc7 with SMTP id z14-20020a170906814e00b007c0d7b0fbc7mr11407945ejw.261.1670329294552; Tue, 06 Dec 2022 04:21:34 -0800 (PST) Received: from [192.168.10.30] (121-6-142-46.pool.kielnet.net. [46.142.6.121]) by smtp.gmail.com with ESMTPSA id i4-20020a056402054400b0046c64b0efdbsm927280edx.33.2022.12.06.04.21.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 04:21:33 -0800 (PST) Message-ID: Date: Tue, 6 Dec 2022 13:21:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] net: ipv6: Add missing break into IPv6 protocol handler Content-Language: en-US To: Viacheslav Mitrofanov Cc: rfried.dev@gmail.com, joe.hershberger@ni.com, wd@denx.de, u-boot@lists.denx.de, judge.packham@gmail.com, linux@yadro.com References: <20221206070816.2453839-1-v.v.mitrofanov@yadro.com> From: Daniel Schwierzeck In-Reply-To: <20221206070816.2453839-1-v.v.mitrofanov@yadro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 12/6/22 08:08, Viacheslav Mitrofanov wrote: > IPv6 protocol handler is not terminated with a break statment. > It can lead to running unexpected code. > > Signed-off-by: Viacheslav Mitrofanov > --- > net/net.c | 1 + > 1 file changed, 1 insertion(+) > thanks for the quick fix Reviewed-by: Daniel Schwierzeck > diff --git a/net/net.c b/net/net.c > index 1c39acc493..57da9bda85 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -1269,6 +1269,7 @@ void net_process_received_packet(uchar *in_packet, int len) > #if IS_ENABLED(CONFIG_IPV6) > case PROT_IP6: > net_ip6_handler(et, (struct ip6_hdr *)ip, len); > + break; > #endif > case PROT_IP: > debug_cond(DEBUG_NET_PKT, "Got IP\n"); -- - Daniel