public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 0/4] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
Date: Mon, 22 Apr 2019 20:40:52 +0200	[thread overview]
Message-ID: <fcfbaa8e-e8b2-69a7-02ef-b3d2e37437b2@gmail.com> (raw)
In-Reply-To: <20190422143641.GZ4664@bill-the-cat>

Am 22.04.2019 um 16:36 schrieb Tom Rini:
> On Thu, Apr 18, 2019 at 10:12:36PM +0200, Simon Goldschmidt wrote:
>> Heinrich,
>>
>> On 02.04.19 19:19, Heinrich Schuchardt wrote:
>>> The SPL image for the Tinker Board has to fit into 32 KiB. This includes
>>> up to 2 KiB for the file header.
>>>
>>> A new configuration variable CONFIG_SPL_SIZE_LIMIT is introduced to define
>>> the board specific limit.
>>>
>>> A common Makefile function is used for this test and the test against
>>> CONFIG_BOARD_SIZE_LIMIT.
>>>
>>> Move the board size check from arch/arm/mach-imx/Makefile to Makefile.
>>
>> Has anything from this series been applied? I now have a working patch that
>> applies on top of this and adds a full SPL SRAM size check (including HEAP,
>> GD and stack; via a host tool) which works for socfpga (as an example of a
>> platform where SPL binary is loaded to limited SRAM).
>>
>> Actually, my patch would replace your patch 3/4 but build on 1/4 (2/4 and
>> 4/4 are arch-specific).
>>
>> How should we proceed here? I could send a series including your 1/4, or I
>> could send a series completely building on this series, at the downside of
>> more or less reverting your 2/4.
> 
> What I would like to see is i.MX (and rockchip) converted to use your
> new test as well (also, yay!  Thanks for following up on that!) and we
> drop the existing check here.
> 

Ok, so while I cannot really help on i.MX and rockchip, why don't you 
accept this series from Heinrich and I'll send my patch as followup? 
Then we can discuss this with i.MX and rockchip maintainers.

Regards,
Simon

  reply	other threads:[~2019-04-22 18:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02 17:19 [U-Boot] [PATCH v4 0/4] configs: rk3288: Tinker Board SPL file must fit into 32 KiB Heinrich Schuchardt
2019-04-02 17:19 ` [U-Boot] [PATCH v4 1/4] Makefile: reusable function for BOARD_SIZE_CHECK Heinrich Schuchardt
2019-06-07 22:04   ` Tom Rini
2019-04-02 17:19 ` [U-Boot] [PATCH v4 2/4] imx: move BOARD_SIZE_CHECK to main Makefile Heinrich Schuchardt
2019-04-04 20:53   ` Heinrich Schuchardt
2019-04-05 13:05   ` Fabio Estevam
2019-04-07 21:10     ` Heinrich Schuchardt
2019-06-07 22:04   ` Tom Rini
2019-04-02 17:19 ` [U-Boot] [PATCH v4 3/4] configs: define CONFIG_SPL_SIZE_LIMIT Heinrich Schuchardt
2019-06-07 22:05   ` Tom Rini
2019-06-07 22:13     ` Fabio Estevam
2019-06-08  0:38       ` Tom Rini
2019-04-02 17:19 ` [U-Boot] [PATCH v4 4/4] configs: rk3288: Tinker Board SPL file must fit into 32 KiB Heinrich Schuchardt
2019-06-07 22:05   ` Tom Rini
2019-04-02 17:29 ` [U-Boot] [PATCH v4 0/4] " Tom Rini
2019-04-02 17:33   ` Heinrich Schuchardt
2019-04-02 17:47     ` Tom Rini
2019-04-02 18:17       ` Heinrich Schuchardt
2019-04-02 18:08     ` Simon Goldschmidt
2019-04-03  0:59 ` Kever Yang
2019-04-03  6:19   ` Heinrich Schuchardt
2019-04-03 20:50     ` Benoît Thébaudeau
2019-04-18 20:12 ` Simon Goldschmidt
2019-04-22 14:36   ` Tom Rini
2019-04-22 18:40     ` Simon Goldschmidt [this message]
2019-04-22 19:29       ` Tom Rini
2019-04-22 19:50         ` Simon Goldschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcfbaa8e-e8b2-69a7-02ef-b3d2e37437b2@gmail.com \
    --to=simon.k.r.goldschmidt@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox