From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 454E4C46467 for ; Wed, 4 Jan 2023 17:27:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2069E85589; Wed, 4 Jan 2023 18:27:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Uj7d/7dz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 324168558A; Wed, 4 Jan 2023 18:27:45 +0100 (CET) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C62568557E for ; Wed, 4 Jan 2023 18:27:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x82d.google.com with SMTP id a16so27733691qtw.10 for ; Wed, 04 Jan 2023 09:27:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QXD9vgQP33WjmSNhkYYjFwqSnzb6zeN7M7ZiTQTZ0x0=; b=Uj7d/7dztJU/0hROwkIvld1CJY7ejnNlENBlphT3bm+lFB2q0DF1cGkO1VOsUAQNY8 DaGloFoT+bAzviTrOv8QOY0F4yrnirRlbKKHiKQv2AilVyiqYWN2eH5VSdc0OE8W6PiW avx/GhhLaKa5Yz0AFbI+cVBXh3G+Ry2DQE7oeKan6P+2lnUJY1cRCfED21cdpOii881D RGlCASu07lDjQ3PZO1L9UuJUzl1nKwx97HOqLMQ3nhgJ7OxbqvrW0cO8JIqysZ8dCBVU tLAiCcXBtFqRPyuoLRNnMQn7eAciCOaNRKKmfPCcKMAmHTfzCUVA+C3Z4thEa2OdaKaZ Wvqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QXD9vgQP33WjmSNhkYYjFwqSnzb6zeN7M7ZiTQTZ0x0=; b=5bigKQdmU/VI68EZbu3Xo+pUHkwMmfKxUSF7TkORtnfcmSuPcDl0/A2zbhxPTu7KkL ZLtTWdsmOw29Mt+T6Eu1YV6sisBcLRm1N7SUEUJVxskezkMwZ/dc4mX5iciLb1M+4w66 R9covBN1++ghIAR7MwGWD5ttIZIf2WsR6Y/4Dh3RnrkHpFd5SWpDZNQUJx4jfFrrpngm vetaANuZq1Wv+CaPLVZyCqJMoTvif+c7m6Jrz8zvNupLNSsXv9FA2TwyWKktccW0QUnm pxamDsr050yQ7kFWOFmiTIG1/SPSE+4e2HapAKmiOVbhdSSpnd+MrF0c/0TGXvSG5l47 4N2w== X-Gm-Message-State: AFqh2kpPo+kKlxTzGItsaatR7HrW6k7qBtRJZ5Vt6EG0AsgB+MxFlTJJ tdT5u2DPi5i+3E8ZdFOwIuiMs42hSjM= X-Google-Smtp-Source: AMrXdXua/38lR78xx8HNaFDNODieHZjY9UYHDIGrKOjkFUa6euhGv6dBLh8I97Z0z9RVbrIt7FYdWQ== X-Received: by 2002:ac8:4646:0:b0:3a4:3137:79b6 with SMTP id f6-20020ac84646000000b003a4313779b6mr76550601qto.24.1672853261631; Wed, 04 Jan 2023 09:27:41 -0800 (PST) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id do42-20020a05620a2b2a00b006fcc3858044sm24538855qkb.86.2023.01.04.09.27.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 09:27:41 -0800 (PST) Message-ID: Date: Wed, 4 Jan 2023 12:27:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/3] clk: imx8mn: fix imx8mn_enet_phy_sels clocks list Content-Language: en-US To: Dario Binacchi , u-boot@lists.denx.de Cc: linux-amarula@amarulasolutions.com, Lukasz Majewski References: <20221219113127.528282-1-dario.binacchi@amarulasolutions.com> <20221219113127.528282-4-dario.binacchi@amarulasolutions.com> From: Sean Anderson In-Reply-To: <20221219113127.528282-4-dario.binacchi@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 12/19/22 06:31, Dario Binacchi wrote: > [backport from linux commit 2626cf67f20b28446dfc3a5b9493dd535cdb747b] > > According to the "Clock Root" table of the reference manual (document > IMX8MNRM Rev 2, 07/2022): > > Clock Root offset Source Select (CCM_TARGET_ROOTn[MUX]) > ... ... ... > ENET_PHY_REF_CLK_ROOT 0xAA80 000 - 24M_REF_CLK > 001 - SYSTEM_PLL2_DIV20 > 010 - SYSTEM_PLL2_DIV8 > 011 - SYSTEM_PLL2_DIV5 > 100 - SYSTEM_PLL2_DIV2 > 101 - AUDIO_PLL1_CLK > 110 - VIDEO_PLL_CLK > 111 - AUDIO_PLL2_CLK > ... ... ... > > while the imx8mn_enet_phy_sels list didn't contained audio_pll1_out for > source select bits 101b. > > Signed-off-by: Dario Binacchi > > --- > > drivers/clk/imx/clk-imx8mn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c > index a2c7c63ef74d..692823e74b88 100644 > --- a/drivers/clk/imx/clk-imx8mn.c > +++ b/drivers/clk/imx/clk-imx8mn.c > @@ -41,7 +41,7 @@ static const char *imx8mn_enet_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m", > "clk_ext3", "clk_ext4", "video_pll_out", }; > > static const char *imx8mn_enet_phy_sels[] = {"clock-osc-24m", "sys_pll2_50m", "sys_pll2_125m", "sys_pll2_200m", > - "sys_pll2_500m", "video_pll_out", "audio_pll2_out", }; > + "sys_pll2_500m", "audio_pll1_out", "video_pll_out", "audio_pll2_out", }; > #endif > > static const char *imx8mn_nand_usdhc_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_200m", Acked-by: Sean Anderson