From: Fabio Estevam <festevam@denx.de>
To: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
Cc: Ariel D'Alessandro <ariel.dalessandro@collabora.com>,
open list <u-boot@lists.denx.de>, Stefano Babic <sbabic@denx.de>,
linux-amarula@amarulasolutions.com
Subject: Re: [PATCH] board: bsh: Update imx8mn ddr3l timing according to BSH hw team
Date: Wed, 31 Aug 2022 09:11:46 -0300 [thread overview]
Message-ID: <fd9697ddc8d5cfa3bdcd295ed7590361@denx.de> (raw)
In-Reply-To: <CAOf5uwnj6Uy-V7fc8HnxjQ09jeNA50X7Hf11i_ZR=VsRmN2g2g@mail.gmail.com>
Hi Michael,
On 31/08/2022 09:06, Michael Nazzareno Trimarchi wrote:
> Hi Fabio
>
> On Mon, Aug 22, 2022 at 12:14 PM Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
>>
>> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
>> ---
>
> Time to review or ask for changes?
The patch looks good and I trust that the changes improve stability
of the board.
The only comment is that it is always good to include something
in the commit log to explain why the change is done.
With a commit log added:
Reviewed-by: Fabio Estevam <festevam@denx.de>
Regards,
Fabio Estevam
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email:
festevam@denx.de
next prev parent reply other threads:[~2022-08-31 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 10:14 [PATCH] board: bsh: Update imx8mn ddr3l timing according to BSH hw team Michael Trimarchi
2022-08-31 12:06 ` Michael Nazzareno Trimarchi
2022-08-31 12:11 ` Fabio Estevam [this message]
2022-08-31 12:13 ` Michael Nazzareno Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd9697ddc8d5cfa3bdcd295ed7590361@denx.de \
--to=festevam@denx.de \
--cc=ariel.dalessandro@collabora.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=michael@amarulasolutions.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox