From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F4ACECAAD1 for ; Wed, 31 Aug 2022 12:11:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8DD93849BC; Wed, 31 Aug 2022 14:11:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1661947910; bh=gdl8ioteQL2xzqMwYMYEt6UmTLbekgtxkmhleQBtXQQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=am1jTXv7OAQzcx/2CXRIN6W6TLdovjYM1W6YTx3JYe78OhGnSCz1dKIbboACmbakZ SmCq3vJZf8QUGQGVDs/1FX46r9YO75Eleqzn3NE/yl03P7aZdWLJNHBvH+5NRHawvr kMevVMcgGxcl0+PIJudFP0ei1l85H2t/E8VRJZ0NcbM9qOWGRVXlXKrxSlUs85QnfU gqyKqf6oTaVLwdqM7ejVMC6OUWyYxHfSIA53U4XCDWaENEicZsRPg35ZY36ny9c8QT HPlpuZPkc4/cX7yOwTGkV2WUKYM7ZzsfWvcXeuhT1Tfqxv1MXJwgib8Ni+BUA9V3eo 4j1J785/MvI8w== Received: from mail.denx.de (unknown [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: festevam@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2A260849C0; Wed, 31 Aug 2022 14:11:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1661947907; bh=gdl8ioteQL2xzqMwYMYEt6UmTLbekgtxkmhleQBtXQQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SRmqjEvoj7/nEbTSY8ZgOihNZcs33hF25CfcJpCS8SwVQTh7epkpOR166uOfyubWI 6RJPFBULY58NtE02YODONVGA4oJt8/mZMLKlcK8m7VyZC+2EBhWhsuE42xl1EE1ikV 6Scqse5z799QMmO75uHoejzTP6TioVDFb1KVKHgaujF/Qf2AH/AqBXPHwNrxkiRwg3 kK+mfFnC0xyPuT+ASn4PobyWjFlPFtSVNkSOqMyUPR+d9yniPXkcpDPE/J+c61pbWG ahHWtBa4P1jbObr784UVp4vXsVVJyMYBIZGe96id4gVdbnAW8IAsWkNSXERW0d6BaS 7BmN0dAPg6z/w== MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 31 Aug 2022 09:11:46 -0300 From: Fabio Estevam To: Michael Nazzareno Trimarchi Cc: Ariel D'Alessandro , open list , Stefano Babic , linux-amarula@amarulasolutions.com Subject: Re: [PATCH] board: bsh: Update imx8mn ddr3l timing according to BSH hw team In-Reply-To: References: <20220822101438.2106079-1-michael@amarulasolutions.com> Message-ID: X-Sender: festevam@denx.de User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Michael, On 31/08/2022 09:06, Michael Nazzareno Trimarchi wrote: > Hi Fabio > > On Mon, Aug 22, 2022 at 12:14 PM Michael Trimarchi > wrote: >> >> Signed-off-by: Michael Trimarchi >> --- > > Time to review or ask for changes? The patch looks good and I trust that the changes improve stability of the board. The only comment is that it is always good to include something in the commit log to explain why the change is done. With a commit log added: Reviewed-by: Fabio Estevam Regards, Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: festevam@denx.de