From: Stefan Roese <sr@denx.de>
To: Tony Dinh <mibodhi@gmail.com>,
U-Boot Mailing List <u-boot@lists.denx.de>
Cc: "Tom Rini" <trini@konsulko.com>,
"David Purdy" <david.c.purdy@gmail.com>,
"Pali Roh�r" <pali@kernel.org>,
"Marek Beh�n" <marek.behun@nic.cz>
Subject: Re: [PATCH] arm: kirkwood: Pogoplug V4 : Use Marvel network PHY driver
Date: Tue, 25 Jan 2022 16:49:06 +0100 [thread overview]
Message-ID: <fdd45cd2-eeb7-19b3-a0ce-ead476bf6c8d@denx.de> (raw)
In-Reply-To: <20220125094846.14504-1-mibodhi@gmail.com>
On 1/25/22 10:48, Tony Dinh wrote:
> The Pogoplug V4 board has the network chip Marvell 88E1118R. So to
> properly configure the network, enable CONFIG_PHY_MARVELL to activate
> the driver M88E1118R.
>
> - This patch depends on the series:
> https://patchwork.ozlabs.org/project/uboot/patch/20220124061712.28316-2-mibodhi@gmail.com/
>
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
I was wondering, how all this "magically" works without the Marvell PHY
driver being involved. ;) So:
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
>
> configs/pogo_v4_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig
> index 5490067b9e..1cf409c834 100644
> --- a/configs/pogo_v4_defconfig
> +++ b/configs/pogo_v4_defconfig
> @@ -62,6 +62,7 @@ CONFIG_KIRKWOOD_GPIO=y
> CONFIG_MVEBU_MMC=y
> CONFIG_MTD=y
> CONFIG_MTD_RAW_NAND=y
> +CONFIG_PHY_MARVELL=y
> CONFIG_DM_ETH=y
> CONFIG_MVGBE=y
> CONFIG_MII=y
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
next prev parent reply other threads:[~2022-01-25 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 9:48 [PATCH] arm: kirkwood: Pogoplug V4 : Use Marvel network PHY driver Tony Dinh
2022-01-25 15:49 ` Stefan Roese [this message]
2022-01-25 21:37 ` Tony Dinh
2022-01-31 11:32 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdd45cd2-eeb7-19b3-a0ce-ead476bf6c8d@denx.de \
--to=sr@denx.de \
--cc=david.c.purdy@gmail.com \
--cc=marek.behun@nic.cz \
--cc=mibodhi@gmail.com \
--cc=pali@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox