From: Tirumala Marri <tmarri@apm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] APM82xxx: Add Common register definitions
Date: Mon, 30 Aug 2010 11:45:58 -0700 [thread overview]
Message-ID: <feaab0fb0610d7155ebbbb57a9f34ac7@mail.gmail.com> (raw)
In-Reply-To: <20100829085648.49A37157D71@gemini.denx.de>
> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Sunday, August 29, 2010 1:57 AM
> To: tmarri at apm.com
> Cc: u-boot at lists.denx.de; open-source-review at apm.com
> Subject: Re: [U-Boot] [PATCH 2/8] APM82xxx: Add Common register
> definitions
>
> Dear tmarri at apm.com,
>
> In message <1282856749-24425-1-git-send-email-tmarri@apm.com> you
> wrote:
> > From: Tirumala Marri <tmarri@apm.com>
> >
> > This patch adds APM82XXX specific definitions, which include
> > clock and boot strap.
> >
> > Signed-off-by: Tirumala R Marri <tmarri@apm.com>
> > ---
> > include/ppc440.h | 57
> ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > include/ppc4xx.h | 7 +++--
> > 2 files changed, 59 insertions(+), 5 deletions(-)
>
> It makes no sense to split this into a spearate patch. Please squash
> into the commit where these defines are first referenced.
>
Mr Wolfgang,
Sure will fix it.
Regards,
Marri
prev parent reply other threads:[~2010-08-30 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 21:05 [U-Boot] [PATCH 2/8] APM82xxx: Add Common register definitions tmarri at apm.com
2010-08-27 9:03 ` Stefan Roese
2010-08-29 8:56 ` Wolfgang Denk
2010-08-30 18:45 ` Tirumala Marri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feaab0fb0610d7155ebbbb57a9f34ac7@mail.gmail.com \
--to=tmarri@apm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox