public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>,
	u-boot@lists.denx.de
Cc: michal.simek@amd.com, git@xilinx.com
Subject: Re: [PATCH] dwc3: Get the ref clock from the child node(dwc3)
Date: Tue, 9 May 2023 16:46:52 +0200	[thread overview]
Message-ID: <ff34ca54-cff8-be8b-eefb-264c9737bf8a@denx.de> (raw)
In-Reply-To: <20230509041125.25609-1-venkatesh.abbarapu@amd.com>

On 5/9/23 06:11, Venkatesh Yadav Abbarapu wrote:
> Currently the parent node(dwc3) ref_clk is updated to the
> dwc3->ref_clk, but we need to update the child node(dwc3)
> "ref" clock to the dwc3->ref_clk.
> For versal SOC, the parent node(usb) ref_clk is updated to dwc3->ref_clk
> which is USB3_DUAL_REF, whereas it should contain the child node(dwc3)
> "ref" clk i.e., USB0_BUS_REF. With this once we trigger "usb start"
> the device is crashing.
> For ZynqMP SOC, crash is not observed because the parent node(usb)
> ref_clk and the child node(dwc3) "ref" clk is pointing to same
> USB3_DUAL_REF clock.
> Fix this by directly updating the child node(dwc3) "ref" clk to
> dwc3->ref_clk from the dwc3_of_parse() function.
> 
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
> ---
> TBD: Need to port the clocks patch from linux kernel

I will wait for a proper backport of all the missing patches, not just a 
subset.

Also, this is clearly a work-in-progress patch, please mark it as 
"[RFC]" next time.

      reply	other threads:[~2023-05-09 14:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  4:11 [PATCH] dwc3: Get the ref clock from the child node(dwc3) Venkatesh Yadav Abbarapu
2023-05-09 14:46 ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff34ca54-cff8-be8b-eefb-264c9737bf8a@denx.de \
    --to=marex@denx.de \
    --cc=git@xilinx.com \
    --cc=michal.simek@amd.com \
    --cc=u-boot@lists.denx.de \
    --cc=venkatesh.abbarapu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox