From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F192BC77B75 for ; Tue, 9 May 2023 14:47:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1D8CE85CA9; Tue, 9 May 2023 16:46:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1683643615; bh=IP7bydM9IT+v/Y0+Dx1NdWjHhS4NZ0XZMEQSP6eqUB8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y45RBRalIy7T1ocQYZRocpTXQB+JREW45E1jBM03CGitieJBKis8y9Mp3kMe0e5fZ HNU4A9xXyVEv9/nA870e/giyfa666JE4umA+2SBsABJVV5EZg39rrqHx2t7MLnej70 uxJrmu7nUE1D0fGRlrgnyPDhxpQ1YaV+62L0jUkakm2EPFu9D9eHruF5BnKEpJH5/E 7M42yJ3Ue5tDarg36nlxBjcGN89cIvwQHkESnCUE1+r/mhydVBRvt+nlx/6nz/uJBS 9KVsmj2TDCMhCQI3GFbMBg8BtKAaKaAgjpy8AsTbsyPpui6olTLMRlglUbPlPHLQ4j zjxDnOUdYcgtg== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2A02A8477D; Tue, 9 May 2023 16:46:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1683643613; bh=IP7bydM9IT+v/Y0+Dx1NdWjHhS4NZ0XZMEQSP6eqUB8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=H7bjfK9DAOo0Ap48xGtSIU7HMWJTfAb2TXGTOFFj1QjSNiB4Cg6YVleanW6D97Dga 5AXttAgxy5/1/esu9CzkA4xkSe3b6sEnEX2UX8j9fJQLd6oR+3DuQaVLGyTW6MXKSq pBSryjKP1U5MPY1io1N8iQB6LJ7ZVI56chtWZk1fJR0afmoLk79ecyM/+xRkA4k5ec bSV9Il7y55esuFkD9iMn1Wc5kUOGmNtUgzx2o/o9pVL0j+LVVwey8Plj0LtpcRmEjB DePimUPzYxBAR+ThpvXt97JpkF3sXcKe/nMUDhwZ1s2qx+UDrEOSUNIYBZPeZc3JyJ 0LDTPukIpDnWA== Message-ID: Date: Tue, 9 May 2023 16:46:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] dwc3: Get the ref clock from the child node(dwc3) Content-Language: en-US To: Venkatesh Yadav Abbarapu , u-boot@lists.denx.de Cc: michal.simek@amd.com, git@xilinx.com References: <20230509041125.25609-1-venkatesh.abbarapu@amd.com> From: Marek Vasut In-Reply-To: <20230509041125.25609-1-venkatesh.abbarapu@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 5/9/23 06:11, Venkatesh Yadav Abbarapu wrote: > Currently the parent node(dwc3) ref_clk is updated to the > dwc3->ref_clk, but we need to update the child node(dwc3) > "ref" clock to the dwc3->ref_clk. > For versal SOC, the parent node(usb) ref_clk is updated to dwc3->ref_clk > which is USB3_DUAL_REF, whereas it should contain the child node(dwc3) > "ref" clk i.e., USB0_BUS_REF. With this once we trigger "usb start" > the device is crashing. > For ZynqMP SOC, crash is not observed because the parent node(usb) > ref_clk and the child node(dwc3) "ref" clk is pointing to same > USB3_DUAL_REF clock. > Fix this by directly updating the child node(dwc3) "ref" clk to > dwc3->ref_clk from the dwc3_of_parse() function. > > Signed-off-by: Venkatesh Yadav Abbarapu > --- > TBD: Need to port the clocks patch from linux kernel I will wait for a proper backport of all the missing patches, not just a subset. Also, this is clearly a work-in-progress patch, please mark it as "[RFC]" next time.