From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E15C433EF for ; Wed, 3 Nov 2021 16:22:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BEC360F58 for ; Wed, 3 Nov 2021 16:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BEC360F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 31A148347E; Wed, 3 Nov 2021 17:22:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lCxy8rd0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 79D0983538; Wed, 3 Nov 2021 17:22:37 +0100 (CET) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DD70A8342C for ; Wed, 3 Nov 2021 17:22:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x832.google.com with SMTP id x10so949769qta.6 for ; Wed, 03 Nov 2021 09:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dp83LKJA+O/4xp8wLawUy8QCfrBvxngIiBHFyhp5KOU=; b=lCxy8rd0nzoQIXOyFos6+GqwZp3RqJy7RSWCBVwRYGLaZFczsOeps0/hjVcLz+nBGM T5zuRE8NJ/YBpfc2Icu0zCi9KwCiNp7Bstfy3yG5XRKHBNgDdg8wUanEE2k92+3VvkPT sLvlJdJJ2wDzT6F/InkZS4LQ/yC3R77c0KnTd40oNmx+N1RfgfBmt5KU29iZyjIxU9J7 FAb/wq5RsRldFOUpqN5EZZhi7ot5jRrgnLd8MP0QvK5Een4AlswwhYH4rl3KUQL0lw9x /LgsAaLhFZZMJ3nIx/HQILU+Ih8+LSApCFO87vWldNio3lg3AkVGe6NASP4S3RdkZLPu XXzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dp83LKJA+O/4xp8wLawUy8QCfrBvxngIiBHFyhp5KOU=; b=4m/0ISSnr7HjQjsyqrVP26PpU6NnajJR5kCu2C8Na7Fz2qEFM1F3oaJQTJrczsivyt Vd4z1JQI966v0DyAeBc8GsqEEtvSvulOMjNTu4nI8c0eNDf4tV+nwKeN1i57WCPfgO1Q Q3fepk5dXoKotLwgde3Uacv/lx64aBupTxykHNWEH9J5C4y4m1jHcukvPczkH7IYZW6f lL5RU1T1xu534S/6W804M5hv9UYIpp/JZgpYOrxpwHhsuAwRHq9Nmdn0cJkqThfNHyiz uIDAeCxjiVuRC6NlBEQWd4kn//bWldE0QkINXxFi6ZcpGzDpHusIYW+ThmN+V8KSn/lC dWtw== X-Gm-Message-State: AOAM531LIKoHNySK5IScF/RVsdVC7imz/MTKpqUrR6xAScBYijUsHiqH ooWY0fp+lLyXYQaLmilxMqBQU/HSbfU= X-Google-Smtp-Source: ABdhPJzUJgwGAv4Ghpf0Gmo3vuF9FEZLimVk66UkYcRWblwnSBWAeFODWHTutdANGPBNp2c9VEok9Q== X-Received: by 2002:a05:622a:1354:: with SMTP id w20mr28943417qtk.408.1635956552862; Wed, 03 Nov 2021 09:22:32 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-207-184.washdc.fios.verizon.net. [108.18.207.184]) by smtp.googlemail.com with ESMTPSA id o2sm1952223qtw.17.2021.11.03.09.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Nov 2021 09:22:32 -0700 (PDT) Subject: Re: [PATCH] fastboot: fix fastboot_set_reboot_flag() To: Roman Stratiienko , u-boot@lists.denx.de Cc: sjg@chromium.org, roman.kovalivskyi@globallogic.com, erosca@de.adit-jv.com References: <20210508222524.4511-1-r.stratiienko@gmail.com> From: Sean Anderson Message-ID: Date: Wed, 3 Nov 2021 12:22:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210508222524.4511-1-r.stratiienko@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 5/8/21 6:25 PM, Roman Stratiienko wrote: > In case CONFIG_FASTBOOT_FLASH_MMC_DEV == 0, compile-time condition > is not met and fastboot_set_reboot_flag() fails. > > Fixes: a362ce214f03 ("fastboot: Implement generic fastboot_set_reboot_flag") > Signed-off-by: Roman Stratiienko > --- > drivers/fastboot/fb_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c > index cbcc3683c47..ef399d0c4ab 100644 > --- a/drivers/fastboot/fb_common.c > +++ b/drivers/fastboot/fb_common.c > @@ -91,7 +91,7 @@ void fastboot_okay(const char *reason, char *response) > */ > int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason) > { > -#if CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC_DEV) > +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV > static const char * const boot_cmds[] = { > [FASTBOOT_REBOOT_REASON_BOOTLOADER] = "bootonce-bootloader", > [FASTBOOT_REBOOT_REASON_FASTBOOTD] = "boot-fastboot", > Reviewed-by: Sean Anderson