U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thirupathaiah Annapureddy <thiruan@linux.microsoft.com>
To: u-boot@lists.denx.de
Subject: [PATCH] image: fdt: check "status" of "/reserved-memory" subnodes
Date: Tue, 4 Feb 2020 09:09:03 -0800	[thread overview]
Message-ID: <ff87859f-dec2-3c7e-c0b1-92e4c05b6333@linux.microsoft.com> (raw)
In-Reply-To: <CAAh8qsw=R6yhHbP4FFUi5Jt2QnFAKfCVFO18frS8BBy-PUV0aA@mail.gmail.com>

Thank You Simon for the review. 

May I know what are the next steps in making forward progress on this? 

Best Regards,
Thiru

On 1/7/2020 12:33 AM, Simon Goldschmidt wrote:
> On Tue, Jan 7, 2020 at 7:21 AM Thirupathaiah Annapureddy
> <thiruan@linux.microsoft.com> wrote:
>>
>> boot_fdt_add_mem_rsv_regions() scans the subnodes of
>> "/reserved-memory" and adds them to reserved lmb regions.
>> Currently this scanning does not take into "status" property.
>> Even if the subnode is disabled, it gets added to the
>> reserved lmb regions.
>>
>> This patch checks the "status" property before adding it
>> to reserved lmb regions.
>>
>> Signed-off-by: Thirupathaiah Annapureddy <thiruan@linux.microsoft.com>
> 
> Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> 
>> ---
>>  common/image-fdt.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/image-fdt.c b/common/image-fdt.c
>> index 48388488d9..cf13d655c0 100644
>> --- a/common/image-fdt.c
>> +++ b/common/image-fdt.c
>> @@ -122,7 +122,7 @@ void boot_fdt_add_mem_rsv_regions(struct lmb *lmb, void *fdt_blob)
>>                         /* check if this subnode has a reg property */
>>                         ret = fdt_get_resource(fdt_blob, subnode, "reg", 0,
>>                                                &res);
>> -                       if (!ret) {
>> +                       if (!ret && fdtdec_get_is_enabled(fdt_blob, subnode)) {
>>                                 addr = res.start;
>>                                 size = res.end - res.start + 1;
>>                                 boot_fdt_reserve_region(lmb, addr, size);
>> --
>> 2.24.1
>>

  reply	other threads:[~2020-02-04 17:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07  6:21 [PATCH] image: fdt: check "status" of "/reserved-memory" subnodes Thirupathaiah Annapureddy
2020-01-07  8:33 ` Simon Goldschmidt
2020-02-04 17:09   ` Thirupathaiah Annapureddy [this message]
2020-02-05  0:16     ` Simon Glass
2020-02-05 17:58       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff87859f-dec2-3c7e-c0b1-92e4c05b6333@linux.microsoft.com \
    --to=thiruan@linux.microsoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox