From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F1D6C433F5 for ; Tue, 8 Feb 2022 23:37:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0124283DDF; Wed, 9 Feb 2022 00:37:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="brvy7bAD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2DFB283D4B; Wed, 9 Feb 2022 00:37:31 +0100 (CET) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E8DE383D4B for ; Wed, 9 Feb 2022 00:37:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20220208233722epoutp0461ecdc66692ab1e617a1a27aa7cf101d~R89aaLtT-0242902429epoutp04H for ; Tue, 8 Feb 2022 23:37:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20220208233722epoutp0461ecdc66692ab1e617a1a27aa7cf101d~R89aaLtT-0242902429epoutp04H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1644363442; bh=/wmvT1h6foxTAjcVNgcrRwuiAGvgHhxAZeBqPKkYS2w=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=brvy7bADVpE/YxErL7SY+15s28x2Qq6jZcdoeDOVnjEYUUm/Ef9/GNyecWy5JRaaf SHpiXaehaUzFleutFK3HooN4xA5quTDq/uKLSGK1Br7jG8D0t8jP7r6XXVQvUj7uas I0/q8k1Y9rujXec1DSgOLhi7woxflJQIFp0+fGKA= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20220208233721epcas1p42985e1ffa163d29fc76ffb499e5aa266~R89Z3x2pp2616926169epcas1p4z; Tue, 8 Feb 2022 23:37:21 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.38.233]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4JtfYm71PXz4x9QD; Tue, 8 Feb 2022 23:37:16 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id FE.B9.08277.1AEF2026; Wed, 9 Feb 2022 08:37:06 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20220208233705epcas1p37fe9500a060866aac43749251e78d9e0~R89LKqgeL1075010750epcas1p3R; Tue, 8 Feb 2022 23:37:05 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220208233705epsmtrp1bd366525d04bac43453003cb72c46a18~R89LJ6NY42158421584epsmtrp1c; Tue, 8 Feb 2022 23:37:05 +0000 (GMT) X-AuditID: b6c32a36-203ff70000002055-f0-6202fea19b0b Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id A0.81.08738.1AEF2026; Wed, 9 Feb 2022 08:37:05 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220208233705epsmtip181fd605cc4305a1f07ddab58392a6ba4~R89K7oEbm0033200332epsmtip1j; Tue, 8 Feb 2022 23:37:05 +0000 (GMT) Message-ID: Date: Wed, 9 Feb 2022 08:37:56 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1] mmc: fsl_esdhc_imx: fix watermark level in dma Content-Language: en-US To: Marcel Ziswiler , u-boot@lists.denx.de Cc: Michael Walle , "NXP i . MX U-Boot Team" , Sean Anderson , Marcel Ziswiler , Fabio Estevam , Peng Fan , Stefano Babic From: Jaehoon Chung In-Reply-To: <20220131220831.386771-1-marcel@ziswiler.com> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIJsWRmVeSWpSXmKPExsWy7bCmge6if0xJBov6mCweXvW3aHy8isni x5wrzBZvT29gt/ix6gurRfspH4t591uYLN7u7WS3mPJ4PbsDp8e8WSdYPHbOusvucfbODkaP je92MHk8+/eN3WPTKw+PA3tb2DyOPjjLHsARlW2TkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pm YKhraGlhrqSQl5ibaqvk4hOg65aZA3SdkkJZYk4pUCggsbhYSd/Opii/tCRVISO/uMRWKbUg JafAtECvODG3uDQvXS8vtcTK0MDAyBSoMCE748vSb0wFvdwVUx+fZG1gbOfsYuTkkBAwkdi/ cB5zFyMXh5DADkaJLbe+s0A4nxglGlrWs0E4nxkl5h8/xgbTsuZBHztEYhejxOLrC1khnPeM Eku2XmcCqeIVsJN4/XUWWAeLgIrEgh2L2CDighInZz5hAbFFBSIkXh75C1YvLOAm0dq6mBXE ZhYQl7j1ZD5YXETAXqJ11Wuwm5gFJjBJ/JraCTaITUBHYvu342BFnAJWEmeWzWWBaJaX2P52 DthHEgJbOCQm/vnABHG3i8TEx6uhfhCWeHV8CzuELSXxsr+NHaKhmVFi6ZKDrBBOD6PEv4br UB3GEvuXTgaaxAG0QlNi/S59iLCixM7fcxkhNvNJvPvawwpSIiHAK9HRJgRRoiJx6fVLJphd d5/8hyrxkDg71X8Co+IspHCZheT/WUjemYWwdwEjyypGsdSC4tz01GLDAiN4fCfn525iBKdd LbMdjJPeftA7xMjEwXiIUYKDWUmEV6b7f6IQb0piZVVqUX58UWlOavEhRlNg7ExklhJNzgcm /rySeEMTSwMTMyNjEwtDM0Mlcd5V004nCgmkJ5akZqemFqQWwfQxcXBKNTC5C8gd5WPp/NyT oTzj2GFdFdZ4m4e9sfuzjklVrq7r+6iczCc33zbH/B3bYYuXy5n/fKi0d728O7LOuv3tTfHi KTPXuWXzJs2ex/eyYTMbt/7B+Twrzz6Z/5PtQuc0yaLrn/wXNoaedJq8dhFbv2Vo+c7QvQy/ X6788Mf7kN0Dq8fipbG6NdJ8p6dHO0w99HjytZdTc3cu+6Ge/UM9WWve9vlbVn9t+P/+j0x2 8rHDG1vSjAS0rA6zTVGpmWJ0fNki5jtJ4d8srZO+PIl9XWDLHav4+4GWUFJ/Q3LkldsyEzcv zFC4+sjY9x83++yygKWZzszJHbknbXyP85yMnH0rtLfi5xxvX66PL+QfblqsxFKckWioxVxU nAgABiSmRkQEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42LZdlhJTnfhP6Ykg5unFCweXvW3aHy8isni x5wrzBZvT29gt/ix6gurRfspH4t591uYLN7u7WS3mPJ4PbsDp8e8WSdYPHbOusvucfbODkaP je92MHk8+/eN3WPTKw+PA3tb2DyOPjjLHsARxWWTkpqTWZZapG+XwJXxZek3poJe7oqpj0+y NjC2c3YxcnJICJhIrHnQx97FyMUhJLCDUWLK/0Z2iISUxOenU9m6GDmAbGGJw4eLQcJCAm8Z JX78YwOxeQXsJF5/nQVmswioSCzYsQgqLihxcuYTFhBbVCBCom3ZFGYQW1jATaK1dTEriM0s IC5x68l8JhBbRMBeonXVaxaI+BQmiYYXchD39DJKfJzxAayBTUBHYvu342ANnAJWEmeWzWUB uY1ZQF1i/TwhiF55ie1v5zBPYBSaheSMWUjWzULomIWkYwEjyypGydSC4tz03GLDAqO81HK9 4sTc4tK8dL3k/NxNjOD40tLawbhn1Qe9Q4xMHIyHGCU4mJVEeGW6/ycK8aYkVlalFuXHF5Xm pBYfYpTmYFES573QdTJeSCA9sSQ1OzW1ILUIJsvEwSnVwBQW/zLt5mSF2dmHL0U+FzJOf9Xh 0OgUsCdUP5rntOBnqcnzjosv8J0RyaNhfKUtLWZy8MeK2AW2twuPZFwNi1M7Y7ImO2nijF9/ XqRLLGYqUm6p69A3fnd7geGtqB2HloZlvroY4VXLs/SSaPW7BP0/+2y369/Y0nejZy3flx0T Fm33stSs1/gtsPfQ8dBOxb9nFE3Eg89IThB8vfhF0jW3JQdZ7hqaeDl0a5RzyijEXTN7Hz0/ svV4pp3skuDF12fq8+9/Em2o6/KsNXN71gUXc6OT9tnPrzXL/dIVnpn4eBPnxcDL95bPOPej 9YGwoapK07brX09/mCaxdWfYuSuv/orqiP3Ve+xQmKVvFaDEUpyRaKjFXFScCAD56spsHgMA AA== X-CMS-MailID: 20220208233705epcas1p37fe9500a060866aac43749251e78d9e0 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220131220855epcas1p1a3c5547afa644ae58e98bc7d7ff2baa5 References: <20220131220831.386771-1-marcel@ziswiler.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2/1/22 07:08, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Seems that we need the waterlevel setting not only for PIO mode as > without this at least the i.MX 8M Mini won't boot anymore when being > written by such a U-Boot. Corruption has also been observed both on > the i.MX 6 as well as i.MX 8M Mini when using ums on the eMMC. Fix > this by setting the watermark level again regardless of whether in > DMA or PIO mode. > > Fixes: 41c6a22fc296 ("mmc: fsl_esdhc_imx: simplify esdhc_setup_data()") > Signed-off-by: Marcel Ziswiler Applied on u-boot-mmc/master. Thanks! Best Regards, Jaehoon Chung > > --- > > drivers/mmc/fsl_esdhc_imx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c > index 9299635f50..efa5ed0af7 100644 > --- a/drivers/mmc/fsl_esdhc_imx.c > +++ b/drivers/mmc/fsl_esdhc_imx.c > @@ -336,9 +336,8 @@ static int esdhc_setup_data(struct fsl_esdhc_priv *priv, struct mmc *mmc, > } > } > > - if (IS_ENABLED(CONFIG_SYS_FSL_ESDHC_USE_PIO)) > - esdhc_setup_watermark_level(priv, data); > - else > + esdhc_setup_watermark_level(priv, data); > + if (!IS_ENABLED(CONFIG_SYS_FSL_ESDHC_USE_PIO)) > esdhc_setup_dma(priv, data); > > /* Calculate the timeout period for data transactions */