From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Goldschmidt Date: Thu, 18 Apr 2019 22:12:36 +0200 Subject: [U-Boot] [PATCH v4 0/4] configs: rk3288: Tinker Board SPL file must fit into 32 KiB In-Reply-To: <20190402171907.17929-1-xypron.glpk@gmx.de> References: <20190402171907.17929-1-xypron.glpk@gmx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Heinrich, On 02.04.19 19:19, Heinrich Schuchardt wrote: > The SPL image for the Tinker Board has to fit into 32 KiB. This includes > up to 2 KiB for the file header. > > A new configuration variable CONFIG_SPL_SIZE_LIMIT is introduced to define > the board specific limit. > > A common Makefile function is used for this test and the test against > CONFIG_BOARD_SIZE_LIMIT. > > Move the board size check from arch/arm/mach-imx/Makefile to Makefile. Has anything from this series been applied? I now have a working patch that applies on top of this and adds a full SPL SRAM size check (including HEAP, GD and stack; via a host tool) which works for socfpga (as an example of a platform where SPL binary is loaded to limited SRAM). Actually, my patch would replace your patch 3/4 but build on 1/4 (2/4 and 4/4 are arch-specific). How should we proceed here? I could send a series including your 1/4, or I could send a series completely building on this series, at the downside of more or less reverting your 2/4. Regards, Simon > > v4: > use a common function for all size checks in the Makefiles > > Heinrich Schuchardt (4): > Makefile: reusable function for BOARD_SIZE_CHECK > imx: move BOARD_SIZE_CHECK to main Makefile > configs: define CONFIG_SPL_SIZE_LIMIT > configs: rk3288: Tinker Board SPL file must fit into 32 KiB > > Kconfig | 8 ++++++++ > Makefile | 33 +++++++++++++++++++++++---------- > arch/arm/mach-imx/Makefile | 16 ---------------- > configs/tinker-rk3288_defconfig | 1 + > 4 files changed, 32 insertions(+), 26 deletions(-) > > -- > 2.20.1 >