From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38616C001B0 for ; Wed, 9 Aug 2023 20:14:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 351C78662F; Wed, 9 Aug 2023 22:14:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lugWiNos"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D57B8866B5; Wed, 9 Aug 2023 22:14:35 +0200 (CEST) Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AB1B084698 for ; Wed, 9 Aug 2023 22:14:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-34983226e16so755025ab.2 for ; Wed, 09 Aug 2023 13:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691612072; x=1692216872; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IIk54Y5qOOSpo3s//RPyDk3zYw4xwegOFUykoFjM1tA=; b=lugWiNoszKBqbK3TRtjRdGUsKgjOToBKfhat7rv/hHwMQzClB4BdqeRH7W542U4LG6 Io4ZnwgDA3bn6B/4ybAP5uijEqD3LoLlQHUIvL9npNA1O36+eDumnbuOiw75U0fvDi7r nyB5tXUxVir1V8C/kDC5Z7PcQNAGbIdA2kkbaVNBgCS2bkbpUj29J90V4tjYtfiDEaN6 LGB4/XJlYpkQhZncW+PrAgfJdWsxxZVyxmnmroZ5NQ5vEHRBdeB/e7j32xq5t+cmlkoW 1G09IcUWpYte++hj7p4M9lWjMNfzFzLq57TBcy0QLrLeFftrEkEcE4HnaD/ryK4jdilo FL6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691612072; x=1692216872; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IIk54Y5qOOSpo3s//RPyDk3zYw4xwegOFUykoFjM1tA=; b=gY9oI0zwq/s82Tted+Z1E3taerglV8qG+hrYQImcxTV/CaYvjk5pu2gf/eNaLem2i+ mGry5JbY4woOYEdN4wSzjFBWDqru1k7VzhPrS7YuzgLtl1ga3oL+32/nunKA3AWab3o7 S0Vark/FJA6cJHb3mGG9uEmXUPJgpi6vcDOf5Ro8J7xchzrioNoGXb57wih+nACTrYqf oaA7o4eJ2EZ+QKntjN0pNeVgBg/S/YmSZ43AJR//y2in8aHbnWvYklfRT7rQ+9gb4rDb /pLvgGWfagdCGI/RtIpkgK3BDrhqSlTSfz3duebQe+hgV25OKSZxd1/U2cGMxkVTFFGj 58gA== X-Gm-Message-State: AOJu0YwzVI11wkQJwCQvYPUP8Kb81nPRX1a0PlA55vTihUPfxEzx2w4F ZmL1pOBXrSTOs+jS81ey56I= X-Google-Smtp-Source: AGHT+IH59EFi5I3PtFKyl5yKQnh4PRoO6EZLck3W9zIkaZ3xVJlygFHSTfdIqpxLQYvWgPy4b2BrNQ== X-Received: by 2002:a05:6e02:16c9:b0:348:b910:313d with SMTP id 9-20020a056e0216c900b00348b910313dmr180895ilx.14.1691612072089; Wed, 09 Aug 2023 13:14:32 -0700 (PDT) Received: from ?IPV6:2001:470:42c4:101:6e71:1f10:2120:d11d? ([2001:470:42c4:101:6e71:1f10:2120:d11d]) by smtp.gmail.com with ESMTPSA id u3-20020a056e02080300b0034989b3cf17sm346622ilm.6.2023.08.09.13.14.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 13:14:31 -0700 (PDT) Message-ID: Date: Wed, 9 Aug 2023 14:14:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 03/20] pinctrl: sunxi: add GPIO in/out wrappers Content-Language: en-US To: Andre Przywara , Jagan Teki , u-boot@lists.denx.de Cc: Samuel Holland , Jernej Skrabec , Icenowy Zheng , Maxim Kiselev , linux-sunxi@lists.linux.dev References: <20230721134606.4505-1-andre.przywara@arm.com> <20230721134606.4505-4-andre.przywara@arm.com> From: Sam Edwards In-Reply-To: <20230721134606.4505-4-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/21/23 07:45, Andre Przywara wrote: > So far we were open-coding the pincontroller's GPIO output/input access > in each function using that. > > Provide functions that wrap that nicely, and follow the existing pattern > (set/get_{bank,}), so users don't need to know about the internals, and > we can abstract the new D1 pinctrl more easily. > > Signed-off-by: Andre Przywara Reviewed-by: Sam Edwards Tested-by: Sam Edwards Thanks, Sam