public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Niklaus Giger <niklaus.giger@member.fsf.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ppc4xx: Fix compilation warnings and coding style issues in HCU4/HCU5
Date: Thu, 17 Jan 2008 21:03:21 +0100	[thread overview]
Message-ID: <fmoca6$6vi$1@ger.gmane.org> (raw)
In-Reply-To: 1200576918-24956-1-git-send-email-sr@denx.de

 Hi Stefan 
 
Thanks for fixing the compile warnings. I fixed my compilation script to
look for warnings in order to fix these kind of problems before submitting
to the u-boot list.

[..] 
> diff --git a/board/netstal/hcu4/Makefile b/board/netstal/hcu4/Makefile 
> index c0d719f..b13d9d4 100644 
> --- a/board/netstal/hcu4/Makefile 
> +++ b/board/netstal/hcu4/Makefile 
> @@ -27,11 +27,11 @@ vpath hcu_flash.c ../common 
>  vpath nm_bsp.c ../common 
>   
>  # NOBJS : Netstal common objects 
> -NOBJS        = fixed_sdram.o hcu_flash.o nm_bsp.o 
> +NOBJS        = ../common/fixed_sdram.o ../common/hcu_flash.o \ 
> ../common/nm_bsp.o 
>  COBJS        = $(BOARD).o 
>  SOBJS        = 
>   
> -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) ../common/$(NOBJS:.o=.c) 
> +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(NOBJS:.o=.c) 
>  OBJS := $(addprefix $(obj),$(COBJS)) 
>  NOBJS        := $(addprefix $(obj),$(NOBJS)) 
>  SOBJS        := $(addprefix $(obj),$(SOBJS)) 

I think that your fixes for the Makefiles are wrong, as they do not work when
one wants to compile out-of-tree. E.g if I specify O=../build, then I get 
errors like 
FATAL: can't create /home/ng/u-boot/build/board/netstal/hcu5/../common/hcu_flash.o: No such file or directory 
 
Is it okay if I submit a patch to revert the changes or do you suggest 
another way how to fix the Makefiles? 
 
Best regards 
 
Niklaus Giger

  reply	other threads:[~2008-01-17 20:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 13:35 [U-Boot-Users] [PATCH] ppc4xx: Fix compilation warnings and coding style issues in HCU4/HCU5 Stefan Roese
2008-01-17 20:03 ` Niklaus Giger [this message]
2008-01-18  6:45   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='fmoca6$6vi$1@ger.gmane.org' \
    --to=niklaus.giger@member.fsf.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox