[U-Boot] [PATCH V2 1/1] IXP425: Fixing PCI access

Wolfgang Denk
2008-12-15T23:29:05Z

Dear Stefan Althoefer,

In message <ghetg9$bcs$1@ger.gmane.org> you wrote:
> This patch fixes the PCI handling routines of the IXP port.
> It seems that this hasn't been touched for quite a while and
> u-boot PCI handling has changed since then (but nobody
> update IXP).
>
> Changes (list uncomplete):
> - non_prefetched_read/write now return ERROR on
> (master-) abort.
> - fixed pci configuration space access.
> - pci_read_config_XXX now return value 0xff even in
> case of error (as some callers do not check the
> return value)
> - Removed CONFIG_PCI_SCAN_SHOW, as printf is not
> possible at the time pci_scan is called initially
> - fixed some IXP initialization of memory spaces
> - fixed address and irq assignment to PCI devices
> - fixed pci_find_device
> - some reformatting

I think most (all?) of my coding style comments for theold version of
this patch still apply and need to be addressed.

> Note: I think boards should always define IXP425_PCI_SIMPLE_MAPPING

In this case IXP425_PCI_SIMPLE_MAPPING should be eliminated.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
That's the thing about people who think they hate computers. What
they really hate is lousy programmers.
- Larry Niven and Jerry Pournelle in "Oath of Fealty"