From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Althoefer Date: Tue, 16 Dec 2008 23:28:39 +0100 Subject: [U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1 In-Reply-To: <20081216215407.GI24266@game.jcrosoft.org> References: <49384721.wZiPCCd4SvLgYfJk%stefan.althoefer@web.de> <49384718.RDeSlY+9Cb0AIN+u%stefan.althoefer@web.de> <20081216215407.GI24266@game.jcrosoft.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jean-Christophe PLAGNIOL-VILLARD schrieb: >> + cfg_clk = *IXP425_EXP_CFG0 >> 21; > please use readx/writex The pointer dereference style is used throughout the other files in the IXP port as well. Shouldn't this be handled the same way in all files? >> >> + /* FIXME: is there any need for the jiffies? */ > for the IRQ delay Ok, I overlooked it is used in start.S. -- Stefan