[U-Boot] [PATCH] IXP425: Changing serial port initialization sequence Part 1/1

[U-Boot] [PATCH] IXP425: Changing serial port initialization sequence Part 1/1

[Stefan Althoefer]

[PATCH] IXP425: Changing serial port initialization sequence

On my IXP425 board (Janz emPC-A400), the first few characters of
the u-boot startup message were missing.

I fixed it by enabling the UART before all other initialization.

I also enabled (and flushed) the FIFO of the UART.


The patch is against "latest" u-boot git-repository

Please (still) be patient if style of submission or patches are
offending.

Signed-off-by: Stefan Althoefer <stefan.althoefer@web.de>
----

diff -uprN u-boot-orig//cpu/ixp/serial.c u-boot/cpu/ixp/serial.c
--- u-boot-orig//cpu/ixp/serial.c	2008-12-02 17:25:31.000000000 +0100
+++ u-boot/cpu/ixp/serial.c	2008-12-02 22:46:27.000000000 +0100
@@ -50,8 +50,10 @@ void serial_setbrg (void)
 	else
 		hang ();
 
-	IER(uart) = 0;					/* Disable for now */
-	FCR(uart) = 0;					/* No fifos enabled */
+	IER(uart) = IER_UUE;
+
+	/* Enable an clear FIFOs */
+	FCR(uart) = FCR_RESETTF | FCR_RESETRF | FCR_TRFIFOE;
 
 	/* set baud rate */
 	LCR(uart) = LCR_WLS0 | LCR_WLS1 | LCR_DLAB;
@@ -63,7 +65,6 @@ void serial_setbrg (void)
 #else
 	MCR(uart) = 0;					/* set RTS inactive */
 #endif
-	IER(uart) = IER_UUE;
 }
 
 /*

[U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

[Stefan Althoefer]

[PATCH] IXP425: Improving print_cpuinfo code

The existing version of print_cpuinfo did read the
processor ID and detects clock speed from this.

This is not correct, as the IXP425 has the ability
to "downgrade" clock speed by using strapping resistors.

The improved code reads strapping information from
register and corrects the actual clock speed. Both
information are displayed.


The patch is against "latest" u-boot git-repository

Please (still) be patient if style of submission or patches are
offending.

Signed-off-by: Stefan Althoefer <stefan.althoefer@web.de>
----

diff -uprN u-boot-orig//cpu/ixp/cpu.c u-boot/cpu/ixp/cpu.c
--- u-boot-orig//cpu/ixp/cpu.c	2008-12-02 17:25:31.000000000 +0100
+++ u-boot/cpu/ixp/cpu.c	2008-12-03 11:35:37.000000000 +0100
@@ -45,32 +45,68 @@ DECLARE_GLOBAL_DATA_PTR;
 int print_cpuinfo (void)
 {
 	unsigned long id;
+	unsigned long cfg_clk;
 	int speed = 0;
+	int model = 0;
 
 	asm ("mrc p15, 0, %0, c0, c0, 0":"=r" (id));
+	cfg_clk = *IXP425_EXP_CFG0 >> 21;
 
-	puts("CPU:   Intel IXP425 at ");
+	puts("CPU:   Intel IXP42X");
 	switch ((id & 0x000003f0) >> 4) {
 	case 0x1c:
-		loops_per_jiffy = 887467;
-		speed = 533;
+		model = 533;
+		switch (cfg_clk) {
+		case 0x1:
+			speed = 400;
+			break;
+		case 0x3:
+			speed = 266;
+			break;
+		default:
+			speed = 533;
+			break;
+		}
 		break;
 
 	case 0x1d:
-		loops_per_jiffy = 666016;
-		speed = 400;
+		model = 400;
+		switch (cfg_clk) {
+		case 0x3:
+			speed = 266;
+			break;
+		default:
+			speed = 400;
+			break;
+		}
 		break;
 
 	case 0x1f:
-		loops_per_jiffy = 442901;
+		model = 266;
 		speed = 266;
 		break;
 	}
 
+	/* FIXME: is there any need for the jiffies? */
+	switch (speed) {
+	case 266:
+		loops_per_jiffy = 442901;
+		break;
+	case 400:
+		loops_per_jiffy = 666016;
+		break;
+	case 533:
+		loops_per_jiffy = 887467;
+		break;
+	}
+
+	if (model)
+		printf("-%d", model);
+
 	if (speed)
-		printf("%d MHz\n", speed);
+		printf(" at %d MHz\n", speed);
 	else
-		puts("unknown revision\n");
+		puts(" unknown revision\n");
 
 	return 0;
 }

[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

[Stefan Althoefer]

[PATCH] ARM: add IDE init to lib_arm/board.c

This patch adds ide_init() to the arm boot process.


The patch is against "latest" u-boot git-repository

Please (still) be patient if style of submission or patches are
offending.

Signed-off-by: Stefan Althoefer <stefan.althoefer@web.de>
----

diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c
--- u-boot-orig//lib_arm/board.c	2008-12-02 17:25:32.000000000 +0100
+++ u-boot/lib_arm/board.c	2008-12-02 23:29:36.000000000 +0100
@@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co
 	}
 #endif
 
+#if defined(CONFIG_CMD_IDE)
+        puts("IDE:   ");
+        ide_init();
+#endif /* CONFIG_CMD_IDE */
+
 #ifdef BOARD_LATE_INIT
 	board_late_init ();
 #endif

[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

[Jean-Christophe PLAGNIOL-VILLARD]

On 22:08 Thu 04 Dec     , Stefan Althoefer wrote:
> [PATCH] ARM: add IDE init to lib_arm/board.c
> 
> This patch adds ide_init() to the arm boot process.
> 
> 
> The patch is against "latest" u-boot git-repository
> 
> Please (still) be patient if style of submission or patches are
> offending.
> 
> Signed-off-by: Stefan Althoefer <stefan.althoefer@web.de>
> ----
> 
> diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c
> --- u-boot-orig//lib_arm/board.c	2008-12-02 17:25:32.000000000 +0100
> +++ u-boot/lib_arm/board.c	2008-12-02 23:29:36.000000000 +0100
> @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co
>  	}
>  #endif
>  
> +#if defined(CONFIG_CMD_IDE)
> +        puts("IDE:   ");
> +        ide_init();
> +#endif /* CONFIG_CMD_IDE */
are you sure it will work?

Best Regards,
J.

[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

[Stefan Althoefer]

Jean-Christophe PLAGNIOL-VILLARD schrieb:

>>
>> diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c
>> --- u-boot-orig//lib_arm/board.c	2008-12-02 17:25:32.000000000 +0100
>> +++ u-boot/lib_arm/board.c	2008-12-02 23:29:36.000000000 +0100
>> @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co
>>  	}
>>  #endif
>>  
>> +#if defined(CONFIG_CMD_IDE)
>> +        puts("IDE:   ");
>> +        ide_init();
>> +#endif /* CONFIG_CMD_IDE */
> are you sure it will work?
> 
> Best Regards,
> J.

On my board (Janz emPC-A400 with IXP425) it does. With some more
patches to add IDE to this board.

What is your doubt?

If you see problems, drop this. I can also add IDE to board_late_init().

-- Stefan

[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

[michael]

Stefan Althoefer wrote:
> Jean-Christophe PLAGNIOL-VILLARD schrieb:
>
>   
>>> diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c
>>> --- u-boot-orig//lib_arm/board.c	2008-12-02 17:25:32.000000000 +0100
>>> +++ u-boot/lib_arm/board.c	2008-12-02 23:29:36.000000000 +0100
>>> @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co
>>>  	}
>>>  #endif
>>>  
>>> +#if defined(CONFIG_CMD_IDE)
>>> +        puts("IDE:   ");
>>> +        ide_init();
>>> +#endif /* CONFIG_CMD_IDE */
>>>       
>> are you sure it will work?
>>
>> Best Regards,
>> J.
>>     
>
> On my board (Janz emPC-A400 with IXP425) it does. With some more
> patches to add IDE to this board.
>
> What is your doubt?
>
> If you see problems, drop this. I can also add IDE to board_late_init().
>   
I don't sure if the outsw/insw are implemented in arm.

Regards Michael

[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

[michael]

michael wrote:
> Stefan Althoefer wrote:
>   
>> Jean-Christophe PLAGNIOL-VILLARD schrieb:
>>
>>   
>>     
>>>> diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c
>>>> --- u-boot-orig//lib_arm/board.c	2008-12-02 17:25:32.000000000 +0100
>>>> +++ u-boot/lib_arm/board.c	2008-12-02 23:29:36.000000000 +0100
>>>> @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co
>>>>  	}
>>>>  #endif
>>>>  
>>>> +#if defined(CONFIG_CMD_IDE)
>>>> +        puts("IDE:   ");
>>>> +        ide_init();
>>>> +#endif /* CONFIG_CMD_IDE */
>>>>       
>>>>         
>>> are you sure it will work?
>>>
>>> Best Regards,
>>> J.
>>>     
>>>       
>> On my board (Janz emPC-A400 with IXP425) it does. With some more
>> patches to add IDE to this board.
>>
>> What is your doubt?
>>
>> If you see problems, drop this. I can also add IDE to board_late_init().
>>   
>>     
> I don't sure if the outsw/insw are implemented in arm.
>
> Regards Michael
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>   
Well, I'm not sure :( if the outsw/insw are implemented in arm.

Regards Michael

[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

[Jean-Christophe PLAGNIOL-VILLARD]

On 14:10 Wed 17 Dec     , michael wrote:
> michael wrote:
> > Stefan Althoefer wrote:
> >   
> >> Jean-Christophe PLAGNIOL-VILLARD schrieb:
> >>
> >>   
> >>     
> >>>> diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c
> >>>> --- u-boot-orig//lib_arm/board.c	2008-12-02 17:25:32.000000000 +0100
> >>>> +++ u-boot/lib_arm/board.c	2008-12-02 23:29:36.000000000 +0100
> >>>> @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co
> >>>>  	}
> >>>>  #endif
> >>>>  
> >>>> +#if defined(CONFIG_CMD_IDE)
> >>>> +        puts("IDE:   ");
> >>>> +        ide_init();
> >>>> +#endif /* CONFIG_CMD_IDE */
> >>>>       
> >>>>         
> >>> are you sure it will work?
> >>>
> >>> Best Regards,
> >>> J.
> >>>     
> >>>       
> >> On my board (Janz emPC-A400 with IXP425) it does. With some more
> >> patches to add IDE to this board.
> >>
> >> What is your doubt?
> >>
> >> If you see problems, drop this. I can also add IDE to board_late_init().
> >>   
> >>     
> > I don't sure if the outsw/insw are implemented in arm.
> >
> > Regards Michael
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> >
> >   
> Well, I'm not sure :( if the outsw/insw are implemented in arm.
IIRC they are not. I'll check but in u-boot we do not have the asm
implementtion.

Best Regards,
J.

[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

[Stefan Althoefer]

Jean-Christophe PLAGNIOL-VILLARD schrieb:
> On 14:10 Wed 17 Dec     , michael wrote:
>> michael wrote:
>>> Stefan Althoefer wrote:
>>>   
>>>> Jean-Christophe PLAGNIOL-VILLARD schrieb:
>>>>
>>>>   
>>>>     
>>>>>> diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c
>>>>>> --- u-boot-orig//lib_arm/board.c	2008-12-02 17:25:32.000000000 +0100
>>>>>> +++ u-boot/lib_arm/board.c	2008-12-02 23:29:36.000000000 +0100
>>>>>> @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co
>>>>>>  	}
>>>>>>  #endif
>>>>>>  
>>>>>> +#if defined(CONFIG_CMD_IDE)
>>>>>> +        puts("IDE:   ");
>>>>>> +        ide_init();
>>>>>> +#endif /* CONFIG_CMD_IDE */
>>>>>>       
>>>>>>         
>>>>> are you sure it will work?
>>>>>
>>>>> Best Regards,
>>>>> J.
>>>>>     
>>>>>       
>>>> On my board (Janz emPC-A400 with IXP425) it does. With some more
>>>> patches to add IDE to this board.
>>>>
>>>> What is your doubt?
>>>>
>>>> If you see problems, drop this. I can also add IDE to board_late_init().
>>>>   
>>>>     
>>> I don't sure if the outsw/insw are implemented in arm.
>>>
>>> Regards Michael
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>
>>>   
>> Well, I'm not sure :( if the outsw/insw are implemented in arm.
> IIRC they are not. I'll check but in u-boot we do not have the asm
> implementtion.
> 
> Best Regards,
> J.

Indeed, I have patched ide.c so it does not use insw/outsw
if compiled for my board. Refer to patch with msg-id
<49384735.e5PYiIdAjpxLwq8V%stefan.althoefer@web.de> to see
what I did.

-- Stefan

[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

[michael]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 22:08 Thu 04 Dec     , Stefan Althoefer wrote:
>   
>> [PATCH] ARM: add IDE init to lib_arm/board.c
>>
>> This patch adds ide_init() to the arm boot process.
>>
>>
>> The patch is against "latest" u-boot git-repository
>>
>> Please (still) be patient if style of submission or patches are
>> offending.
>>
>> Signed-off-by: Stefan Althoefer <stefan.althoefer@web.de>
>> ----
>>
>> diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c
>> --- u-boot-orig//lib_arm/board.c	2008-12-02 17:25:32.000000000 +0100
>> +++ u-boot/lib_arm/board.c	2008-12-02 23:29:36.000000000 +0100
>> @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co
>>  	}
>>  #endif
>>  
>> +#if defined(CONFIG_CMD_IDE)
>> +        puts("IDE:   ");
>> +        ide_init();
>> +#endif /* CONFIG_CMD_IDE */
>>     
> are you sure it will work?
>
> Best Regards,
> J.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>   
I submit a patch series for ide support in ARM. I don't think that it 
will work

Michael

[U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

[Jean-Christophe PLAGNIOL-VILLARD]

On 22:09 Thu 04 Dec     , Stefan Althoefer wrote:
> [PATCH] IXP425: Improving print_cpuinfo code
> 
> The existing version of print_cpuinfo did read the
> processor ID and detects clock speed from this.
> 
> This is not correct, as the IXP425 has the ability
> to "downgrade" clock speed by using strapping resistors.
> 
> The improved code reads strapping information from
> register and corrects the actual clock speed. Both
> information are displayed.
> 
> 
> The patch is against "latest" u-boot git-repository
> 
> Please (still) be patient if style of submission or patches are
> offending.
> 
> Signed-off-by: Stefan Althoefer <stefan.althoefer@web.de>
> ----
> 
> diff -uprN u-boot-orig//cpu/ixp/cpu.c u-boot/cpu/ixp/cpu.c
> --- u-boot-orig//cpu/ixp/cpu.c	2008-12-02 17:25:31.000000000 +0100
> +++ u-boot/cpu/ixp/cpu.c	2008-12-03 11:35:37.000000000 +0100
> @@ -45,32 +45,68 @@ DECLARE_GLOBAL_DATA_PTR;
>  int print_cpuinfo (void)
>  {
>  	unsigned long id;
> +	unsigned long cfg_clk;
>  	int speed = 0;
> +	int model = 0;
>  
>  	asm ("mrc p15, 0, %0, c0, c0, 0":"=r" (id));
> +	cfg_clk = *IXP425_EXP_CFG0 >> 21;
please use readx/writex 
>  
> -	puts("CPU:   Intel IXP425 at ");
> +	puts("CPU:   Intel IXP42X");
>  	switch ((id & 0x000003f0) >> 4) {
>  	case 0x1c:
> -		loops_per_jiffy = 887467;
> -		speed = 533;
> +		model = 533;
> +		switch (cfg_clk) {
> +		case 0x1:
> +			speed = 400;
> +			break;
> +		case 0x3:
> +			speed = 266;
> +			break;
> +		default:
> +			speed = 533;
> +			break;
> +		}
>  		break;
>  
>  	case 0x1d:
> -		loops_per_jiffy = 666016;
> -		speed = 400;
> +		model = 400;
> +		switch (cfg_clk) {
> +		case 0x3:
> +			speed = 266;
> +			break;
> +		default:
> +			speed = 400;
> +			break;
> +		}
>  		break;
>  
>  	case 0x1f:
> -		loops_per_jiffy = 442901;
> +		model = 266;
>  		speed = 266;
>  		break;
>  	}
>  
> +	/* FIXME: is there any need for the jiffies? */
	for the IRQ delay
> +	switch (speed) {
> +	case 266:
> +		loops_per_jiffy = 442901;
> +		break;
> +	case 400:
> +		loops_per_jiffy = 666016;
> +		break;
> +	case 533:
> +		loops_per_jiffy = 887467;
> +		break;
> +	}
Best Regards,
J.

[U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

[Stefan Althoefer]

Jean-Christophe PLAGNIOL-VILLARD schrieb:
>> +	cfg_clk = *IXP425_EXP_CFG0 >> 21;
> please use readx/writex 

The pointer dereference style is used throughout the
other files in the IXP port as well. Shouldn't this
be handled the same way in all files?

>>  
>> +	/* FIXME: is there any need for the jiffies? */
> 	for the IRQ delay

Ok, I overlooked it is used in start.S.

-- Stefan

[U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

[Jean-Christophe PLAGNIOL-VILLARD]

On 23:28 Tue 16 Dec     , Stefan Althoefer wrote:
> Jean-Christophe PLAGNIOL-VILLARD schrieb:
> >> +	cfg_clk = *IXP425_EXP_CFG0 >> 21;
> > please use readx/writex 
> 
> The pointer dereference style is used throughout the
> other files in the IXP port as well. Shouldn't this
> be handled the same way in all files?
yes it's old wrong way code
for new we to use the good accessor

for old code patch are welcome

Best Regards,
J.