[U-Boot] [PATCH 2/2] at91sam9263ek: active watchdog support via at91sam9263ek_wdt_config

Jean-Christophe PLAGNIOL-VILLARD
2009-03-09T08:39:46Z

On 00:15 Mon 09 Mar , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <1232623377-26351-3-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > Makefile | 5 +++++
> > include/configs/at91sam9263ek.h | 5 +++++
> > 2 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index c3f089d..2fb0c42 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2663,6 +2663,7 @@ at91sam9261ek_config : unconfig
> > at91sam9263ek_nandflash_config \
> > at91sam9263ek_dataflash_config \
> > at91sam9263ek_dataflash_cs0_config \
> > +at91sam9263ek_wdt_config \
> > at91sam9263ek_config : unconfig
> > @mkdir -p $(obj)include
> > @if [ "$(findstring _nandflash,$@)" ] ; then \
> > @@ -2672,6 +2673,10 @@ at91sam9263ek_config : unconfig
> > echo "#define CONFIG_SYS_USE_DATAFLASH 1" >>$(obj)include/config.h ; \
> > $(XECHO) "... with environment variable in SPI DATAFLASH CS0" ; \
> > fi;
> > + @if [ "$(findstring _wdt_, $@)" ] ; then \
> > + echo "#define CONFIG_AT91SAM9_WATCHDOG" >> $(obj)include/config.h ; \
> > + $(XECHO) "... configured with watchdog active"; \
> > + fi
> > @$(MKCONFIG) -a at91sam9263ek arm arm926ejs at91sam9263ek atmel at91
>
> Sorry for the late reply - but this makes no sense to me.
>
> CONFIG_ settings belong into the board config file, where a user
> expects to find user configurable settings.
>
> Why would the use of the watchdog be restricted like here? Why would
> it be not possible to use it in combination with USE_NANDFLASH or with
> USE_DATAFLASH?

It's possible but do we really need to add 4 new configs?

or just one and a doc how to use it?

Best Regards,
J.