[U-Boot] [PATCH 2/2] at91sam9263ek: active watchdog support via at91sam9263ek_wdt_config

Wolfgang Denk
2009-03-09T11:19:54Z

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090309083946.GG24237@game.jcrosoft.org> you wrote:
>
> > > @@ -2663,6 +2663,7 @@ at91sam9261ek_config : unconfig
> > > at91sam9263ek_nandflash_config \
> > > at91sam9263ek_dataflash_config \
> > > at91sam9263ek_dataflash_cs0_config \
> > > +at91sam9263ek_wdt_config \
> > > at91sam9263ek_config : unconfig
> > > @mkdir -p $(obj)include
...
> > Sorry for the late reply - but this makes no sense to me.
> >
> > CONFIG_ settings belong into the board config file, where a user
> > expects to find user configurable settings.
> >
> > Why would the use of the watchdog be restricted like here? Why would
> > it be not possible to use it in combination with USE_NANDFLASH or with
> > USE_DATAFLASH?
>
> It's possible but do we really need to add 4 new configs?

I did not say that I'm a big fan of things like USE_NANDFLASH and
USE_DATAFLASH and the like. I did not invent this code.

> or just one and a doc how to use it?

I don't see how flash device usage and watchdog usage are related or
how you could handle these in one config option. that doesn't make
sense to me.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Death, when unnecessary, is a tragic thing.
-- Flint, "Requiem for Methuselah", stardate 5843.7