public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] at91sam9263ek: active watchdog support	via at91sam9263ek_wdt_config
Date: Mon, 15 Jun 2009 12:38:07 +0200	[thread overview]
Message-ID: <h158eq$otj$1@ger.gmane.org> (raw)
In-Reply-To: 20090613123700.GD3814@game.jcrosoft.org

Jean-Christophe PLAGNIOL-VILLARD wrote:

> On 12:52 Sat 13 Jun     , Giulio Benetti wrote:
>> In this way the linux driver won't work(the one by Renaud CERRATO).
>> Because it expects MR register not to be set, or to be set enabled.
> it's work we have test it
> you need to enable it in the at91bootstrap or in your lowlevel board
> config
>> 
>> After I don't agree refreshing watchdog inside atmel_usart.c
> you MUST do it otherwise you board will be not usable at all
> simple exammple
> you stop the boot and get a prompt if you do not type any command you
> reboot it's not what we expect
>> If u-boot hangs there instead of execute bootcmd, then the machine lies
>> there forever.
>> In my opinion we should put WATCHDOG_RESET() inside main_loop and nand
>> write and read.
>> What do you think?
> NACK for the main_loop
> 
> nand read write ok
> 
> but if we excecute the bootcmd we have finished and jump to the os
> so it's over for u-boot
> 
> the OS will have to care about the watchdog
> 
> Best Regards,
> J.

Agree with you.
But you have to delete hw_watchdog_init().
If you set there MR then linux won't be able to do it.
The patch needs only the WATCHDOG_RESET() and nothing more.

-- 
Giulio Benetti
R&D
Micronova srl

  reply	other threads:[~2009-06-15 10:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-01 16:29 [U-Boot] [PATCH 1/2] at91sam9: add watchdog support Jean-Christophe PLAGNIOL-VILLARD
2009-02-01 16:29 ` [U-Boot] [PATCH 2/2] at91sam9263ek: active watchdog support via at91sam9263ek_wdt_config Jean-Christophe PLAGNIOL-VILLARD
2009-03-08 23:19   ` Wolfgang Denk
2009-06-13 10:52     ` Giulio Benetti
2009-06-13 12:37       ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-15 10:38         ` Giulio Benetti [this message]
2009-06-15 12:44           ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-15 13:01             ` Alessandro Rubini
2009-06-18 15:30               ` Giulio Benetti
2009-06-13 10:44 ` [U-Boot] [PATCH 1/2] at91sam9: add watchdog support Giulio Benetti
  -- strict thread matches above, loose matches on Subject: below --
2009-01-22 11:22 [U-Boot] [PATCH 0/2] " Jean-Christophe PLAGNIOL-VILLARD
2009-01-22 11:22 ` [U-Boot] [PATCH 1/2] " Jean-Christophe PLAGNIOL-VILLARD
2009-01-22 11:22   ` [U-Boot] [PATCH 2/2] at91sam9263ek: active watchdog support via at91sam9263ek_wdt_config Jean-Christophe PLAGNIOL-VILLARD
2009-03-08 23:15     ` Wolfgang Denk
2009-03-09  8:39       ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-09 11:19         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='h158eq$otj$1@ger.gmane.org' \
    --to=giulio.benetti@micronovasrl.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox