[U-Boot] [PATCH 2/2 V2] update the EB+MCF-EV123 board support

Wolfgang Denk
2009-07-23T19:36:52Z

Dear Jens Scharsig,

In message <h447jv$vm7$3@ger.gmane.org> you wrote:
> This patch updates the support for EB+MCF-EV123 board and needs the [PATCH 1/2 V2] new video driver for bus vcxk framebuffers

Please restrict the line length of the commit message to 70 characters
or less.

...
> +#if defined(CONFIG_VIDEO)
> +
> +/*----------------------------------------------------------------------------
> + ****h* EB+CPU5282-T1/drv_video_init
> + * FUNCTION
> + ***
> +----------------------------------------------------------------------------*/

Incorrect multi-line comment style.

> +int drv_video_init (void)
> +{
> + char *s;
> + unsigned long splash;
> +
> + printf("Init Video as ");
> +
> + if ((s = getenv ("displaywidth")) != NULL)
> + {
> + display_width = simple_strtoul (s, NULL, 10);
> + }
> + else
> + {
> + display_width=256;
> + }
> + if ((s = getenv ("displayheight")) != NULL)
> + {
> + display_height = simple_strtoul (s, NULL, 10);
> + }
> + else
> + {
> + display_height=256;
> + }

Incorrect brace style.

> + printf("%lu x %lu pixel matrix\n",display_width,display_height);

Please s/,/, /g

Please clean up and resubmit.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
News is what a chap who doesn't care much about anything wants to
read. And it's only news until he's read it. After that it's dead.
- Evelyn Waugh _Scoop_ (1938) bk. 1, ch. 5