From: Jens Scharsig <esw@bus-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch] Fix compiler warning vcxk
Date: Tue, 28 Jul 2009 08:18:04 +0200 [thread overview]
Message-ID: <h4m56v$ted$1@ger.gmane.org> (raw)
In-Reply-To: <4A6E93A3.1090306@denx.de>
Anatolij Gustschin wrote:
>
> Please note that comments to the patch should go below "---"
> line so that they do not appear in the commit message, e.g.
> in this case:
>
> This patch will
>
> * FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'
>
> Your SOB
> ---
> Here is the place for comments which should not appear in
> the commit log, in this case this is:
>
> "My new video driver vcxk produce a compiler warning.
>
I think the http://www.denx.de/wiki/U-Boot/Patches is a good
place to describe such basic things. Especially for people
who publish their first patch.
Best regard
Jens
next prev parent reply other threads:[~2009-07-28 6:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 13:28 [U-Boot] [Patch] Fix compiler warning vcxk Jens Scharsig
2009-07-28 5:58 ` Anatolij Gustschin
2009-07-28 6:18 ` Jens Scharsig [this message]
2009-08-09 20:49 ` Wolfgang Denk
2009-08-10 6:16 ` Jens Scharsig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='h4m56v$ted$1@ger.gmane.org' \
--to=esw@bus-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox