public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: rhabarber1848 <rhabarber1848@web.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] zlib: allow 0 as destination pointer
Date: Wed, 29 Jul 2009 08:53:59 +0200	[thread overview]
Message-ID: <h4orm0$l1d$1@ger.gmane.org> (raw)
In-Reply-To: 20090729062355.61B9C832E416@gemini.denx.de

Wolfgang Denk wrote:

> Dear Giuseppe CONDORELLI,
> 
> In message <001601ca1012$e0f72730$c08182a4@st.com> you wrote:
>> Very good!!!
>> So is it time to re-apply zlib patch to u-boot main tree, together
>> Alessandro's patch?
>> 
>> Wolfgang, what's your position?
> 
> Actually I'm waiting for a new patch that integrates that fix.

Hi,

please do not commit the zlib-1.2.3 patch in its current state, although
Alessandro's patch fixes on bug there is still the problem that the
WATCHDOG_RESET() calls from gunzip.c

#if defined(CONFIG_HW_WATCHDOG) || defined(CONFIG_WATCHDOG)
        s.outcb = (cb_func)WATCHDOG_RESET;
#else
        s.outcb = Z_NULL;
#endif<>/* CONFIG_HW_WATCHDOG */

are silently ignored in the new zlib code. My C knowledge is insufficient to
solve this problem. In its current state it will break zlib decompression
on the machines I am taking care of.

Cheers, rhabarber1848

  parent reply	other threads:[~2009-07-29  6:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <05a201ca0ec5@st.com>
2009-07-27 15:09 ` [U-Boot] [PATCH v3] zlib: updated to v.1.2.3 Alessandro Rubini
2009-07-27 15:30   ` Stefan Roese
2009-07-27 16:40     ` [U-Boot] [PATCH] zlib: allow 0 as destination pointer Alessandro Rubini
2009-07-27 18:02       ` rhabarber1848
2009-07-27 18:15         ` Wolfgang Denk
2009-07-27 20:13           ` rhabarber1848
2009-07-27 20:45             ` Wolfgang Denk
2009-07-28  6:31       ` Stefan Roese
2009-07-29  6:07         ` Giuseppe CONDORELLI
2009-07-29  6:23           ` Wolfgang Denk
2009-07-29  6:29             ` Giuseppe CONDORELLI
2009-07-29  7:10               ` Wolfgang Denk
2009-07-29  6:53             ` rhabarber1848 [this message]
2009-07-29  7:11               ` Wolfgang Denk
2009-07-29  8:50                 ` Giuseppe CONDORELLI
     [not found] <002901ca1029@st.com>
2009-07-29  9:20 ` Alessandro Rubini
2009-07-29 10:32   ` rhabarber1848
2009-07-29 10:50     ` Giuseppe CONDORELLI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='h4orm0$l1d$1@ger.gmane.org' \
    --to=rhabarber1848@web.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox