From mboxrd@z Thu Jan 1 00:00:00 1970 From: rhabarber1848 Date: Wed, 29 Jul 2009 08:53:59 +0200 Subject: [U-Boot] [PATCH] zlib: allow 0 as destination pointer References: <001601ca1012$e0f72730$c08182a4@st.com> <20090729062355.61B9C832E416@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Giuseppe CONDORELLI, > > In message <001601ca1012$e0f72730$c08182a4@st.com> you wrote: >> Very good!!! >> So is it time to re-apply zlib patch to u-boot main tree, together >> Alessandro's patch? >> >> Wolfgang, what's your position? > > Actually I'm waiting for a new patch that integrates that fix. Hi, please do not commit the zlib-1.2.3 patch in its current state, although Alessandro's patch fixes on bug there is still the problem that the WATCHDOG_RESET() calls from gunzip.c #if defined(CONFIG_HW_WATCHDOG) || defined(CONFIG_WATCHDOG) s.outcb = (cb_func)WATCHDOG_RESET; #else s.outcb = Z_NULL; #endif<>/* CONFIG_HW_WATCHDOG */ are silently ignored in the new zlib code. My C knowledge is insufficient to solve this problem. In its current state it will break zlib decompression on the machines I am taking care of. Cheers, rhabarber1848