From: Jens Scharsig <esw@bus-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2
Date: Tue, 27 Oct 2009 13:38:29 +0100 [thread overview]
Message-ID: <hc6pk5$tvs$1@ger.gmane.org> (raw)
In-Reply-To: <20091027110234.A0787E916D5@gemini.denx.de>
Wolfgang Denk schrieb:
> Dear Jens Scharsig,
>> +int board_init(void)
>> +{
>> + /* Enable Ctrlc */
>> + console_init_f();
>> +
>> + /* Correct IRDA resistor problem / Set PA23_TXD in Output */
>> + ((AT91PS_PIO) AT91C_BASE_PIOA)->PIO_OER = AT91C_PA23_TXD2;
>
> Please use I/O accessors to access device registers. Please fix
> globally.
Do you mean change to
writel(AT91C_PA23_TXD2, ((AT91PS_PIO) AT91C_BASE_PIOA)->PIO_OER);
like notation
Best regards Jens
next prev parent reply other threads:[~2009-10-27 12:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 8:38 [U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2 Jens Scharsig
2009-10-27 11:02 ` Wolfgang Denk
2009-10-27 12:38 ` Jens Scharsig [this message]
2009-10-27 18:35 ` Wolfgang Denk
2009-10-28 10:10 ` Jens Scharsig
2009-10-28 14:35 ` Wolfgang Denk
2009-10-29 7:40 ` Jens Scharsig
2009-10-29 10:47 ` Wolfgang Denk
2009-10-29 13:41 ` Jens Scharsig
2009-10-29 13:57 ` Tom
2009-10-29 14:56 ` Wolfgang Denk
2009-10-29 15:21 ` Tom
2009-10-30 8:30 ` Wolfgang Denk
2009-10-30 9:10 ` Jens Scharsig
2009-10-27 21:27 ` Scott Wood
2009-10-27 11:44 ` Wolfgang Denk
2009-10-27 15:26 ` Jens Scharsig
2009-10-27 19:04 ` Wolfgang Denk
2009-10-28 14:37 ` [U-Boot] [PATCH V2] " Jens Scharsig
2009-10-28 14:42 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hc6pk5$tvs$1@ger.gmane.org' \
--to=esw@bus-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox