From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jens Scharsig <esw@bus-elektronik.de>
Date: Tue, 27 Oct 2009 13:38:29 +0100
Subject: [U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2
In-Reply-To: <20091027110234.A0787E916D5@gemini.denx.de>
References: <4AE6B186.9030301@bus-elektronik.de>
	<20091027110234.A0787E916D5@gemini.denx.de>
Message-ID: <hc6pk5$tvs$1@ger.gmane.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk schrieb:
> Dear Jens Scharsig,
>> +int board_init(void)
>> +{
>> +	/* Enable Ctrlc */
>> +	console_init_f();
>> +
>> +	/* Correct IRDA resistor problem / Set PA23_TXD in Output */
>> +	((AT91PS_PIO) AT91C_BASE_PIOA)->PIO_OER = AT91C_PA23_TXD2;
> 
> Please use I/O accessors to access device registers. Please fix
> globally.
Do you mean change to

writel(AT91C_PA23_TXD2, ((AT91PS_PIO) AT91C_BASE_PIOA)->PIO_OER);

like notation


Best regards Jens