Re: [PATCH] mtd: spi-nor: Indent SF: just like other boot time messages

[Stefan Monnier <monnier@iro.umontreal.ca>]

E Shattow [2026-10-25 06:29:43] wrote:

> On 10/24/26 11:05, Marek Vasut wrote:
>> On 10/24/26 5:14 PM, Stefan Monnier wrote:
>>>> to the fixed indent:
>>>>
>>>> "
>>>> DRAM:  3.5 GiB
>>>> Core:  310 devices, 34 uclasses, devicetree: separate
>>>> SF:    Detected w25q128jw with page size 256 Bytes, erase size
>>>> 4 KiB, total 16 MiB
>>>>      ^^^
>>>
>>> I'm probably not the targeted audience, but FWIW, I find the meaning of
>>> "SF" non-obvious, so maybe instead of adding spaces, we could use those
>>> 3 extra characters to come up with a slightly more
>>> self-explanatory abbreviation?
>> SF is SPI Flash , it is used all over the code base.

Yes, that's indeed how I figured what it meant, but it would be better
if users could figure that out without having to consult the source code.

> I also find the meaning of "SF" non-obvious, and nothing better comes to
> mind to abbreviate it. You cannot get to "sf" command from "spi flash"
> or "flash" commands. If the probe message would say "SPI [NOR|NAND]
> Flash detected ...." or "SPI: [NOR|NAND] Flash detected ..." it would

How 'bout

    SPI:   16MB flash (w25q128jw) with page size 256 Bytes, erase size 4 KiB


=== Stefan