public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: craig vanderborgh <craigv@voxware.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Re: Trouble on PXA w/kernel command-line
Date: Wed, 15 Dec 2004 02:36:16 +0000 (UTC)	[thread overview]
Message-ID: <loom.20041215T032855-191@post.gmane.org> (raw)
In-Reply-To: 20041214222505.BA3B7C1430@atlas.denx.de

Wolfgang Denk <wd <at> denx.de> writes:

> 
> In message <41BF5D9D.50603 <at> voxware.com> you wrote:
> > 
> > Yes, it is most definitely set.  Could you possibly describe how 
> > command-line passing is *supposed* to work and then I think I can fix it...
> 
> See setup_commandline_tag() and do_bootm_linux() in
> lib_arm/armlinux.c
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 

Hello Wolfgang:

It turns out that u-boot's handling of the command line is PERFECT.  Absolutely
spot-on.  The trouble was on the receiving end of the command line in my kernel.
My machine descriptor (in my processor setup C code) looked like this:

MACHINE_START(BITSYX, "Voxware/ADS BitsyX Lite")
	BOOT_MEM(0xa0000000, 0x40000000, io_p2v(0x40000000))
	MAPIO(bitsyx_map_io)
	INITIRQ(bitsyx_init_irq)
MACHINE_END

It lacked the "BOOT_PARAMS" macro that tells the kernel where in memory to look
for the command line.  Once I added a "BOOT_PARAMS" to my MACHINE descriptor
everything works perfectly:

MACHINE_START(BITSYX, "Voxware/ADS BitsyX Lite")
        BOOT_PARAMS(0xa0000100)
	BOOT_MEM(0xa0000000, 0x40000000, io_p2v(0x40000000))
	MAPIO(bitsyx_map_io)
	INITIRQ(bitsyx_init_irq)
MACHINE_END

I am sorry to bother you with such trivialities, but they are UNDOCUMENTED and
not at all obvious to people who don't regularly do Linux kernel work - like 
myself.

Thanks a MILLION.

Regards,
craig

  reply	other threads:[~2004-12-15  2:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-14 21:07 [U-Boot-Users] Trouble on PXA w/kernel command-line Craig A. Vanderborgh
2004-12-14 21:30 ` Wolfgang Denk
2004-12-14 21:39   ` Craig A. Vanderborgh
2004-12-14 22:25     ` Wolfgang Denk
2004-12-15  2:36       ` craig vanderborgh [this message]
2004-12-15 11:23         ` [U-Boot-Users] " Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20041215T032855-191@post.gmane.org \
    --to=craigv@voxware.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox