From mboxrd@z Thu Jan  1 00:00:00 1970
From: craig vanderborgh <craigv@voxware.com>
Date: Wed, 15 Dec 2004 02:36:16 +0000 (UTC)
Subject: [U-Boot-Users] Re: Trouble on PXA w/kernel command-line
References: <41BF5D9D.50603@voxware.com> <20041214222505.BA3B7C1430@atlas.denx.de>
Message-ID: <loom.20041215T032855-191@post.gmane.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk <wd <at> denx.de> writes:

> 
> In message <41BF5D9D.50603 <at> voxware.com> you wrote:
> > 
> > Yes, it is most definitely set.  Could you possibly describe how 
> > command-line passing is *supposed* to work and then I think I can fix it...
> 
> See setup_commandline_tag() and do_bootm_linux() in
> lib_arm/armlinux.c
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 

Hello Wolfgang:

It turns out that u-boot's handling of the command line is PERFECT.  Absolutely
spot-on.  The trouble was on the receiving end of the command line in my kernel.
My machine descriptor (in my processor setup C code) looked like this:

MACHINE_START(BITSYX, "Voxware/ADS BitsyX Lite")
	BOOT_MEM(0xa0000000, 0x40000000, io_p2v(0x40000000))
	MAPIO(bitsyx_map_io)
	INITIRQ(bitsyx_init_irq)
MACHINE_END

It lacked the "BOOT_PARAMS" macro that tells the kernel where in memory to look
for the command line.  Once I added a "BOOT_PARAMS" to my MACHINE descriptor
everything works perfectly:

MACHINE_START(BITSYX, "Voxware/ADS BitsyX Lite")
        BOOT_PARAMS(0xa0000100)
	BOOT_MEM(0xa0000000, 0x40000000, io_p2v(0x40000000))
	MAPIO(bitsyx_map_io)
	INITIRQ(bitsyx_init_irq)
MACHINE_END

I am sorry to bother you with such trivialities, but they are UNDOCUMENTED and
not at all obvious to people who don't regularly do Linux kernel work - like 
myself.

Thanks a MILLION.

Regards,
craig