From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] CONFIG_RESET_PHY_R feature is broken
Date: Wed, 18 Aug 2010 08:47:35 +0000 (UTC) [thread overview]
Message-ID: <loom.20100818T103421-560@post.gmane.org> (raw)
In-Reply-To: 4C6B858F.9060201@free.fr
Hello Albert,
Albert ARIBAUD <albert.aribaud <at> free.fr> writes:
> At the moment your problem is not being able to reset the PHY at times
> other than boot, i.e. the 'PHY API' would be limited to reset_phy()
> which is pretty much board-specific anyway.
The problem is the PHY being reseted by the driver and going to unworking state.
We need the board-specific quirk to bring PHY back to life and driver knows
nothing about this quirk.
> What prevents simply adding
> calls to reset_phy() to the driver?
Yes, we can just add calls to reset_phy() to the driver and we actually have
this solution as a simplest one in our options list. But this solution seems to
be imperfect: there are more drivers using 'on demand' PHY init, we need to add
calls to reset_phy() to each of them. Furthermore, if somebody will want to
switch some driver from early PHY initialization to on demand intialization he
will have to remember about adding reset_phy() call. So it is error prone.
So we'd like to discuss if there are cleaner solutions.
Regards, Ilya.
PS could use please reply not only to the ML but to me also? Thanks!
next prev parent reply other threads:[~2010-08-18 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 23:16 [U-Boot] [RFC] CONFIG_RESET_PHY_R feature is broken Ilya Yanok
2010-08-18 7:02 ` Albert ARIBAUD
2010-08-18 7:52 ` Wolfgang Denk
2010-08-18 8:47 ` Ilya Yanok [this message]
2010-08-18 10:30 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20100818T103421-560@post.gmane.org \
--to=yanok@emcraft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox